Fix for nightly release#853
Merged
Merged
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in the nightly GitHub Actions workflow that was causing the workflow to fail during execution. The fix involves correcting the order and format of output variable assignments in the tags computation step.
- Removes the
all_tagsoutput variable that was incorrectly formatted - Reorders the remaining output variables for better readability
- Maintains the same functionality while fixing the workflow failure
Comments suppressed due to low confidence (2)
.github/workflows/nightly.yml:95
- The
all_tagsoutput variable is being referenced but was removed in the tags computation step. This will cause the workflow to fail as the variable no longer exists.
tags: ${{ steps.meta.outputs.all_tags }}
.github/workflows/nightly.yml:109
- The
all_tagsoutput variable is being referenced but was removed in the tags computation step. This will cause the workflow to fail as the variable no longer exists.
tags: ${{ steps.meta.outputs.all_tags }}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
philon-
approved these changes
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a typo that made its way into the nightly github action workflow. A typo made its way into the tags step in the github action which caused it to fail while running. This PR removes that typo.
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)