Fixes to github actions for latest tag#848
Merged
danditomaso merged 3 commits intoSep 13, 2025
Merged
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes GitHub Actions workflows to properly manage the "latest" Docker tag alongside version-specific tags. The changes ensure that the mutable "latest" tag moves to the latest release while maintaining immutable version-specific tags for both release and nightly builds.
- Updates Docker tag strategy to include semver helpers and proper "latest" tag handling
- Improves nightly workflow to create both mutable and immutable tags
- Enhances output formatting and push conditions for better visibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release-web.yml | Adds comprehensive Docker tag strategy with semver helpers, "latest" tag for non-prereleases, and improved metadata handling |
| .github/workflows/nightly.yml | Updates nightly builds to create both moving "nightly" tag and immutable timestamped tags with better output formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| push: ${{ github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && inputs.tag_name != '') }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| provenance: false |
There was a problem hiding this comment.
There's a trailing space after 'false' that should be removed.
Suggested change
| provenance: false | |
| provenance: false |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the mutable tag "latest" is moved to the latest release along with its immutable version tag. This updates both the release-web and nightly workflows.
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)