Allow default overrideFrequency#838
Merged
Merged
Conversation
|
@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a validation issue with the overrideFrequency field by allowing 0 as a valid input to use the default frequency setting.
- Updated validation logic to accept 0 as a special case alongside the existing 410-930 MHz range
- Updated the corresponding error message to clarify that 0 is allowed for using default frequency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web/src/validation/config/lora.ts | Modified validation rule to allow 0 as valid input for overrideFrequency |
| packages/web/public/i18n/locales/en/common.json | Updated error message to document that 0 is valid for using default frequency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
danditomaso
approved these changes
Sep 10, 2025
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent changes to overrideFrequency introduced an issue where 0 was not a valid input. This PR addresses that.
Related Issues
Changes Made
overrideFrequency == 0Testing Done
Tested locally, behaves as expected
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)