Improve the nightly and release workflow#836
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull Request Overview
This PR improves the CI/CD workflow infrastructure by fixing issues with package publishing and container image building. The changes focus on standardizing file extensions, correcting container image configurations, and streamlining release workflows.
- Standardizes package.json entry points from
.mjsto.jsextensions across all packages - Updates container image build processes and nginx base image version
- Simplifies and fixes workflow configurations for release and nightly builds
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web/infra/Containerfile | Updates nginx base image and fixes file paths for container build |
| packages/*/package.json | Standardizes entry point file extensions from .mjs/.mts to .js/.ts |
| .github/workflows/release-web.yml | Simplifies workflow logic and switches to docker/build-push-action |
| .github/workflows/release-packages.yml | Adds version bumping, improves error handling, and streamlines publishing |
| .github/workflows/nightly.yml | Fixes tag reference and removes working directory specification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bergie
left a comment
There was a problem hiding this comment.
The package.json changes look good. The commit date stuff we've discussed separately on Discord.
Thanks! |
Description
This PR contains several fixes for long standing issues. The first is a focus on improving how our release workflow operates, its been failing at different spots and this (hopefully) should fix the remaining issues with releasing packages and our web client. The next is a fix for package publishing, ensuring that we expose the correct files within the package.json and jsr.json file. Lastly, our nightly workflow has been experiencing problems for a while and this should clean up any existing issues with that process.
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)