Remove PWA service worker#834
Merged
danditomaso merged 1 commit intoSep 7, 2025
Merged
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the VitePWA package back to the web application with the purpose of removing existing service workers from users' browsers instead of installing new ones. This is part of an ongoing effort to smoothly remove PWA functionality.
- Added VitePWA dependency to package.json
- Configured VitePWA with
selfDestroying: truedirective to remove service workers - Replaced commented-out PWA configuration with the self-destructing setup
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web/vite.config.ts | Imports VitePWA and configures it with selfDestroying directive to remove service workers |
| packages/web/package.json | Adds vite-plugin-pwa dependency and reorders vite dependency alphabetically |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
philon-
approved these changes
Sep 5, 2025
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the VitePWA package to the web app, but instead of re-install the PWA it will force the service worker to be removed from users browsers.
Related Issues
This has been an ongoing effort to ensure we smoothly remove the PWA service worker.
Changes Made
selfDestroydirective to configTesting Done
Ummm, it works.
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)