Reduced release workflow complexity, added conditional image upload#832
Merged
Merged
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the web release workflow by removing redundant build steps and adding conditional image publishing. The changes ensure that container images are only pushed to the registry for non-prerelease GitHub releases, while maintaining build functionality for all workflow triggers.
Key changes:
- Removed duplicate
pnpm run buildstep to eliminate redundant operations - Simplified Docker image tagging by removing custom tag computation logic
- Added conditional publishing that only pushes images for non-prerelease releases
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
release-web.ymlGitHub Actions workflow to streamline the build and release process for the web app. The main changes remove redundant build steps, simplify image tag computation, and clarify output messaging based on the release type.Workflow simplification and reliability:
pnpm run buildstep in thewebpackage to avoid unnecessary duplicate builds.latest,${{ steps.meta.outputs.tag }}in thebuildah-buildstep, and removed the customCompute image tagsstep.Conditional release behavior:
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)