Fix default filter behaviour#820
Merged
Merged
Conversation
|
@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes filter default boundary behavior where nodes with extreme values (SNR <-20dB or >10dB, voltage >5V) were incorrectly excluded from results. The fix implements open boundaries when filter values equal default boundaries, ensuring such nodes are included rather than filtered out.
Key changes:
- Modified filter logic to use open boundaries when range boundaries equal defaults
- Refactored FilterControl to use a unified RangeLabelContent component that displays boundary semantics with "<" and ">" indicators
- Added comprehensive tests to verify open boundary behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/web/src/components/generic/Filter/useFilterNode.ts | Updated SNR and voltage filtering logic to use open boundaries when values equal defaults |
| packages/web/src/components/generic/Filter/useFilterNode.test.ts | Added test suite covering default boundary semantics for lastHeard, SNR, and voltage filters |
| packages/web/src/components/generic/Filter/FilterControl.tsx | Refactored to use unified RangeLabelContent component and improved code organization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mictronics
added a commit
to Mictronics/meshtastic-web
that referenced
this pull request
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #668 by adjusting filter default-boundary behaviour for SNR and voltage fields. Previously, default range boundaries were bounded and not open, resulting in nodes with <-20dB or >10dB SNR and >5V voltage to be excluded.
Related Issues
Fixes #668
Changes Made
Testing Done
Updated automatic tests
Tested manually
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)