Lint tests, format JSON#818
Merged
Merged
Conversation
|
@philon- is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds linting for test files and automatic formatting for JSON files by updating the Biome configuration. It enables JSON formatting and linting for test files while excluding certain TypeScript rules that are commonly relaxed in test environments.
- Added linting overrides for test files to disable
noExplicitAnyandnoNonNullAssertionrules - Enabled JSON formatting with exclusions for locale files
- Applied automatic formatting and linting fixes to affected files
Reviewed Changes
Copilot reviewed 18 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| biome.json | Updated configuration to include JSON files, enable JSON formatting, and add test file linting overrides |
| packages/web/src/core/stores/nodeDBStore/nodeDBStore.test.ts | Applied linting fixes including brace formatting and whitespace cleanup |
| packages/transport-web-serial/src/transport.test.ts | Applied linting fixes including import reordering and brace formatting |
| packages/transport-web-bluetooth/src/transport.test.ts | Applied linting fixes including import cleanup and brace formatting |
| Multiple package.json files | Applied JSON formatting to tsdown configuration objects |
| Multiple tsconfig.json files | Applied JSON formatting and removed trailing whitespace |
| .vscode/settings.json | Applied JSON formatting to VS Code configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
danditomaso
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds linting for test files, with exceptions for
noExplicitAnyandnoNonNullAssertion, and automatic formatting for all JSON files except non english language files (matching**/locales/*-*/*.json)Related Issues
Changes Made
**/*.test.tsand**/*.test.tsxin Biome config**/*.jsoninclude in Biome config**/locales/*-*/*.jsonexclusion in Biome configTesting Done
Automated tests pass
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)