Fix nightly github action#811
Conversation
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a GitHub Actions workflow issue in the nightly build where an incorrect variable was being used for the Docker image creation timestamp label.
- Fixed the
org.opencontainers.image.createdlabel to use the proper commit timestamp instead of the run ID - Added proper spacing in the workflow configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| org.opencontainers.image.source=${{ github.repository }} | ||
| org.opencontainers.image.revision=${{ github.sha }} | ||
| org.opencontainers.image.created=${{ github.run_id }} | ||
| org.opencontainers.image.created=${{ github.event.head_commit.timestamp }} |
There was a problem hiding this comment.
The github.event.head_commit.timestamp may be null for certain trigger types (like scheduled workflows). Consider using ${{ github.event.repository.updated_at }} or the more reliable ${{ steps.date.outputs.date }} after adding a date generation step to ensure consistent timestamp availability.
Description
This PR fixes a long standing issue with the nightly github action, where it was refactored and tags were incorrectly used during the refactor. This PR corrects that behaviour.
Related Issues
Fixes #810
Changes Made
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)