Skip to content

7279: Prevent browser hang with multiline accDescr in XY charts#7293

Merged
ashishjain0512 merged 1 commit intodevelopfrom
xychart-parsing-issue
Jan 23, 2026
Merged

7279: Prevent browser hang with multiline accDescr in XY charts#7293
ashishjain0512 merged 1 commit intodevelopfrom
xychart-parsing-issue

Conversation

@darshanr0107
Copy link
Copy Markdown
Contributor

@darshanr0107 darshanr0107 commented Jan 6, 2026

📑 Summary

This PR fixes a browser hang (CODE_HUNG) that occurs when adding a multiline accDescr element to an XY chart.

Resolves #7279

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

… and add tests

on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 6, 2026

🦋 Changeset detected

Latest commit: a408b55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 6, 2026

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit a408b55
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/695cf162de96a7000804d516
😎 Deploy Preview https://deploy-preview-7293--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 6, 2026

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@7293

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@7293

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@7293

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@7293

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@7293

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@7293

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@7293

commit: a408b55

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.57%. Comparing base (d5bc07d) to head (a408b55).
⚠️ Report is 86 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7293   +/-   ##
=======================================
  Coverage     3.57%   3.57%           
=======================================
  Files          473     473           
  Lines        47475   47475           
  Branches       734     734           
=======================================
  Hits          1696    1696           
  Misses       45779   45779           
Flag Coverage Δ
unit 3.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jan 6, 2026, 11:38 AM

@DavidSeptimus
Copy link
Copy Markdown
Contributor

@darshanr0107 thanks for taking this on. Unfortunately, I don't have the bandwidth at the moment to onboard myself as a contributor to submit PRs for issues like this.

@ashishjain0512 ashishjain0512 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into develop with commit 553c900 Jan 23, 2026
27 checks passed
@ashishjain0512 ashishjain0512 deleted the xychart-parsing-issue branch January 23, 2026 15:04
This was referenced Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid XY Chart crashes browser tab (CODE_HUNG error)

3 participants