6853: prevent browser freeze caused by invalid participant name in sequenceDiagram#7055
Merged
shubhamparikh2704 merged 4 commits intodevelopfrom Oct 13, 2025
Merged
Conversation
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
🦋 Changeset detectedLatest commit: 6fecb98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7055 +/- ##
=======================================
Coverage 3.55% 3.55%
=======================================
Files 473 473
Lines 47454 47454
Branches 730 730
=======================================
Hits 1687 1687
Misses 45767 45767
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
sidharthv96
approved these changes
Oct 8, 2025
Member
sidharthv96
left a comment
There was a problem hiding this comment.
Not a regex guru, if it works and don't break other tests, looks good to me. 😬
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
omkarht
reviewed
Oct 8, 2025
Co-authored-by: omkarht <omkar@mermaidchart.com>
on-behalf-of: @Mermaid-Chart <hello@mermaidchart.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
Fixes an issue where incorrect participant syntax in sequenceDiagram could cause the browser to hang due to excessive recursion during parsing.
Resolves #6853
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.