Skip to content

Move revert-rule from css.properties.all to css.types.global_keywords#29489

Merged
caugner merged 6 commits into
mdn:mainfrom
pepelsbey:firefox-revert-rule
Apr 22, 2026
Merged

Move revert-rule from css.properties.all to css.types.global_keywords#29489
caugner merged 6 commits into
mdn:mainfrom
pepelsbey:firefox-revert-rule

Conversation

@pepelsbey

@pepelsbey pepelsbey commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Move revert-rule from css.properties.all to css.types.global_keywords, consistent with how all other CSS-wide keywords (initial, inherit, revert, revert-layer, unset) are tracked.
  • Add mdn_url pointing to the new MDN documentation page (WIP).

Test results and supporting details

Related issues

Part of the mdn/content#43552

@pepelsbey pepelsbey requested a review from Elchi3 April 15, 2026 14:40
@github-actions github-actions Bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed labels Apr 15, 2026
@github-actions

github-actions Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

This was referenced Apr 16, 2026
Merged
Merged
Closed
@pepelsbey pepelsbey requested a review from caugner April 17, 2026 14:22
@caugner caugner added the needs collector update This PR needs a corresponding update to openwebdocs/mdn-bcd-collector. label Apr 21, 2026
caugner
caugner requested changes Apr 22, 2026
View reviewed changes

@caugner caugner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this PR also remove the entry in css/properties/all.json?

@pepelsbey

pepelsbey commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

Shouldn't this PR also remove the entry in css/properties/all.json?

That was a part of the initial commit, but then I rebased from main, and this part disappeared. Weird.

@Elchi3 Elchi3 mentioned this pull request Apr 22, 2026
Merged
@pepelsbey pepelsbey requested a review from caugner April 22, 2026 10:26
Elchi3
Elchi3 reviewed Apr 22, 2026
View reviewed changes
Comment thread css/types/global_keywords.json Outdated
@pepelsbey @Elchi3
Update global_keywords.json
24c4085 
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@caugner

caugner commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

@pepelsbey Please see the failing lint. (Reviewdog would have allowed me to easily apply the fixes, and merge.)

@pepelsbey

pepelsbey commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

@caugner done

@caugner caugner merged commit c069846 into mdn:main Apr 22, 2026
9 checks passed
@mdn-bot mdn-bot mentioned this pull request Apr 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elchi3 Elchi3 Elchi3 left review comments

@caugner caugner caugner approved these changes

Assignees

No one assigned

Labels

data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS needs collector update This PR needs a corresponding update to openwebdocs/mdn-bcd-collector. size:m [PR only] 25-100 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pepelsbey @caugner @Elchi3 @mdn-bot