Chrome 148 added Prompt API#29474
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
|
@hamishwillee I've had three checks pending ever since I submitted this. How do I move this forward? |
|
Hi @jmedley! I've approved the checks to run. I think this is always the case with a new account, for the first few PRs. Now we need to find someone to do a review. |
|
@chrisdavidmills Thanks! I've lost access to me old account. |
|
@jpmedley FYI I work on Mozilla stuff on Mon, Tues, Friday in Melbourne, Australia timezone. Which is to say that I only just got into work and saw this. You shouldn't have this problem going forward, but it can take time for the (very busy) BCD team to review. |
…ebview_ios to LanguageModel* files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@hamishwillee, @chrisdavidmills I'm working on the other lint failures, but the location of this spec fails the regex for "spec_url": https://webmachinelearning.github.io/prompt-api/
|
|
A spec url must contain a |
|
@hamishwillee @caugner I forgot to mention that this spec doesn't have fragment identifiers. |
It looks like it does to me. https://webmachinelearning.github.io/prompt-api/, right? As an FYI, text fragments are also acceptable in spec URLs, in cases where there isn't a clear URL fragment to point to a definition. |
caugner
left a comment
There was a problem hiding this comment.
First review round, without looking at the values.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
|
@caugner PTAL Sorry about the mess-ups. I'm a few years rusty. |
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
|
@caugner PTAL |
| "availability_static": { | ||
| "__compat": { | ||
| "spec_url": "https://webmachinelearning.github.io/prompt-api/#dom-languagemodel-availability", |
There was a problem hiding this comment.
This should have had a description. I filed #29537 to have a lint for it in the future.
Summary
Chrome is shipping the Prompt API in 148. See https://chromestatus.com/feature/5134603979063296
Test results and supporting details
I generated a schema from existing BCD and tested the JSON against the schema.
Related issues
Fixes #29473 and mdn/content#43755