Safari 18.4 supports multiple import maps#26648
Merged
Merged
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
approved these changes
Apr 28, 2025
Contributor
There was a problem hiding this comment.
LGTM.
I think the WPT provide sufficient evidence, even if the 18.4 release notes don't mention import maps.
cc @jensimmons
Contributor
Author
|
Thanks for reviewing!! I don't have merge permissions, so don't wait on me to merge this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Given https://wpt.fyi/results/import-maps/multiple-import-maps?label=stable&label=master&aligned, this changes the support matrix for multiple import maps to include Safari 18.4
Test results and supporting details
[https://wpt.fyi/results/import-maps/multiple-import-maps?label=stable&label=master&aligned](WPT tests) show that's the case.
Related issues