Skip to content

Chrome 21 added webextensions.api.events#26622

Merged
caugner merged 1 commit into
mainfrom
webextension-events-in-chrome
Apr 29, 2025
Merged

Chrome 21 added webextensions.api.events#26622
caugner merged 1 commit into
mainfrom
webextension-events-in-chrome

Conversation

@caugner

@caugner caugner commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Summary

Replaces several Chrome version ranges in webextensions.api.events.

Test results and supporting details

See: https://github.com/caugner/chromium-releases/blame/v21/chrome/common/extensions/api/events.json

Related issues

@github-actions github-actions Bot added data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:s [PR only] 7-24 LoC changed labels Apr 25, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@caugner caugner requested a review from rebloor April 25, 2025 12:33
@rebloor

rebloor commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

@caugner does the flagging as internal have any impact here, e.g., did they become public later than 21?

@caugner

caugner commented Apr 28, 2025

Copy link
Copy Markdown
Contributor Author

@caugner does the flagging as internal have any impact here, e.g., did they become public later than 21?

Good question!

I looked into it, and found that the events namespace has always been marked as internal since Chrome 21.

Looking at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/events, it doesn't surprise me that these types are marked as internal. If I understand these types correctly, they aren't used directly.

Although the commit message in Chrome 40 may suggest that events was only made available in that version, I rather think that those types were available since Chrome 21.

@rebloor Does that make sense?

PS: https://developer.chrome.com/docs/extensions/reference/api/events doesn't mention any Chrome version.

@rebloor rebloor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caugner that makes sense, thanks.

@caugner caugner merged commit 10e1a9e into main Apr 29, 2025
@caugner caugner deleted the webextension-events-in-chrome branch April 29, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:s [PR only] 7-24 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants