Update lobster output file list#355
Merged
shyuep merged 10 commits intomaterialsproject:masterfrom May 12, 2025
Merged
Conversation
Member
|
Please have some unittests to make sure that these are dealt with as they should. |
13 tasks
Contributor
Author
|
Hi @shyuep, unit tests have been added now and should be ready to be merged. Happy to address any changes if desired. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 69.67% 69.67%
=======================================
Files 39 39
Lines 3489 3489
=======================================
Hits 2431 2431
Misses 1058 1058 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @JaGeo and @shyuep, I have updated the list of output files from LOBSTER here. These are optional files that can be generated using lobster >=v5.
This should also get gzipped now if a user runs with keywords that enable such calculations.
Todo