Skip to content

Add back additional_criteria as an input to get_entries and get_entries_in_chemsys#693

Merged
munrojm merged 11 commits intomainfrom
enhancement/more_parity
Oct 12, 2022
Merged

Add back additional_criteria as an input to get_entries and get_entries_in_chemsys#693
munrojm merged 11 commits intomainfrom
enhancement/more_parity

Conversation

@munrojm
Copy link
Copy Markdown
Member

@munrojm munrojm commented Oct 12, 2022

additional_criteria in top level entry related methods now passes arguments to MPRester.thermo.search

@munrojm munrojm added the release:patch Patch release label Oct 12, 2022
@munrojm munrojm changed the title Add back additional_criteria as an input to get_entries and get_entries_by_chemsys Add back additional_criteria as an input to get_entries and get_entries_in_chemsys Oct 12, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 85.67% // Head: 87.70% // Increases project coverage by +2.03% 🎉

Coverage data is based on head (c5bd46b) compared to base (9f821a1).
Patch coverage: 84.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   85.67%   87.70%   +2.03%     
==========================================
  Files          36       36              
  Lines        1626     1667      +41     
==========================================
+ Hits         1393     1462      +69     
+ Misses        233      205      -28     
Impacted Files Coverage Δ
mp_api/client/core/settings.py 88.88% <66.66%> (-11.12%) ⬇️
mp_api/client/mprester.py 86.16% <86.66%> (+17.61%) ⬆️
mp_api/client/routes/charge_density.py 65.07% <0.00%> (-23.81%) ⬇️
mp_api/client/routes/tasks.py 90.90% <0.00%> (-4.55%) ⬇️
mp_api/client/core/utils.py 59.61% <0.00%> (+1.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 72eafaa into main Oct 12, 2022
@munrojm munrojm deleted the enhancement/more_parity branch December 6, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:patch Patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants