Skip to content

BREAKING CHANGE: escape html in renderer#3495

Merged
UziTech merged 7 commits intomarkedjs:masterfrom
UziTech:escape-in-renderer
Nov 9, 2024
Merged

BREAKING CHANGE: escape html in renderer#3495
UziTech merged 7 commits intomarkedjs:masterfrom
UziTech:escape-in-renderer

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Oct 21, 2024

Marked version: 14.1.3

Description

Only escape text in renderer instead of in tokenizer.

The tokenizer should only pull the information out of the markdown and put it into tokens. The renderers should take the information from the tokens and output HTML, including escaping where relevant.

This is a breaking change because some extensions will have to update their tokenizers and renderers to follow this pattern.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:42am

@UziTech UziTech changed the title BREAKING CHANGE: escape in renderer BREAKING CHANGE: escape html in renderer Oct 21, 2024
@UziTech UziTech mentioned this pull request Oct 22, 2024
Closed
@UziTech
Copy link
Member Author

UziTech commented Nov 6, 2024

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Nov 6, 2024 •
edited
Loading

@UziTech Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
You are true leader! Other sloths hot on your heels, keep moving!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 20 Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@UziTech UziTech merged commit 58d66e5 into markedjs:master Nov 9, 2024
@race-of-sloths
Copy link

race-of-sloths commented Nov 9, 2024

🥁 Score it!

@styfle, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

github-actions bot pushed a commit that referenced this pull request Nov 9, 2024
@semantic-release-bot
chore(release): 15.0.0 [skip ci]
f66914e 
# [15.0.0](v14.1.4...v15.0.0) (2024-11-09)

### Bug Fixes

* escape html in renderer ([#3495](#3495)) ([58d66e5](58d66e5))
* Move all regexps to rules ([#3519](#3519)) ([1f88deb](1f88deb))

### BREAKING CHANGES

* escape html in renderers for all tokens.
@PikachuEXE PikachuEXE mentioned this pull request Nov 11, 2024
Merged
@stevenjoezhang stevenjoezhang mentioned this pull request Dec 30, 2024
Merged
@UziTech UziTech deleted the escape-in-renderer branch March 6, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

@joshbruce joshbruce Awaiting requested review from joshbruce

@davisjam davisjam Awaiting requested review from davisjam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Suggestion] Provide Escaping Options in Lexer

6 participants

@UziTech @race-of-sloths @styfle @calculuschild @joshbruce @davisjam