Fix output path not validated before the run#2148
Merged
mre merged 3 commits intoApr 19, 2026
Merged
Conversation
mre
reviewed
Apr 17, 2026
mre
reviewed
Apr 17, 2026
Member
|
Thanks for the PR, Kostas. Two minor remarks from my side. |
Contributor
Author
|
Thanks for your input @mre ! I have added the changes you proposed. |
mre
approved these changes
Apr 19, 2026
Member
|
Thanks a lot for the nice contribution. 😃 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The already existing behavior is kept, the only difference being that the checks do not run if the parent directory of the output path does not exist.
lychee --output tmp.txt https://example.comsucceeds even if tmp.txt does not exist (just like before).lychee --output does/not/exist/tmp.txt https://example.comnow fails before checks, since directorydoes/not/exist/does not exists.Note: also affects --dump.
Closes #2147