Add JUnit#2066
Merged
Merged
Conversation
thomas-zahner
commented
Feb 26, 2026
mre
reviewed
Feb 27, 2026
mre
reviewed
Feb 27, 2026
mre
reviewed
Feb 27, 2026
mre
reviewed
Feb 27, 2026
| /// Used to store the duration of the run in seconds. | ||
| pub(crate) duration_secs: u64, | ||
| /// The time it took to perform the full run | ||
| pub(crate) duration: Duration, |
Member
There was a problem hiding this comment.
This is cool and all, and we should keep it. I just want to point out that this is technically a breaking change in the JSON output. E.g. before it was "duration_secs": 0 and I believe now it would be "duration": {"secs": 0, "nanos": 0} or something. Maybe we should point that out in the release notes or in the PR description?
Member
Author
There was a problem hiding this comment.
Yes that makes sense 👍
2a00c0f to
3b0b2a9
Compare
Additionally update ResponseStats' duration
Co-authored-by: Matthias Endler <matthias@endler.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #614
I experimented both with the SARIF and JUnit XML report format. In the end I've settled for JUnit. I feel like the format is more fitting and it's simpler to integrate. In GitLab it's supported out of the box. In GitHub you would normally use an additional action such as action-junit-report. Using this additional action was easier IMO then setting up the code scanning in GitHub to get the SARIF format to properly work. It seems much more programmatic, where with SARIF you have to do some manual adjustments in the settings and the reported errors are considered "security" issues. With JUnit link check results are treated like tests which are passing, failing, or skipped.
I've made a little demo for GitLab and one for GitHub.
This PR also introduces durations response body. See 2e0060c