tests: add tests for the current state of "Checking a Local Folder with URL Remapping"#1965
Merged
Conversation
Merged
1 task
Member
Author
|
Hi can this PR be checked? It is useful tests to have, especially with #2005. Let me know if the PR is too big or hard to understand. |
Conflicts: lychee-bin/tests/cli.rs
Member
|
Sorry for dropping the ball on this. I reviewed it now. |
mre
approved these changes
Apr 3, 2026
Member
|
Looks good to me. 👍 Can this be merged? |
Member
Author
|
Yeah I think so. Whenever you're ready :) |
Member
|
Great! Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds tests for the use case of "Checking a Local Folder with URL Remapping", as motivated in lycheeverse/lycheeverse.github.io#140. it makes no behaviour changes.
to review this PR, i suggest first understanding the use-case, then you can read the input files and expected URLs to check that they make sense. there are two new .md files inside the fixtures folder, one for whole domain mapping and one for subpath mapping. the markdown text explains the reasoning for each URL.
the remaps are deeply unpleasant and you shouldn't try too hard to understand them. they're also different from lycheeverse/lycheeverse.github.io#140 because i found new edge cases and new bugs. i'll update the docs pr after...
issues arising: