Conversation
Member
Author
Member
|
Very quick! I'm wondering whether this affects parsing markdown inside HTML, which should work according to the spec? I think this should already be handled by pulldown-cmark, but maybe add a test case with a markdown link inside a html block? |
Previously, each HTML line inside a Markdown file would be parsed independently. This worked reasonably well, but in the case where individual lines are not valid HTML, we would skip link checking. The fix is to accumulate an HTML block until it gets closed and only _then_ parsing it. Fixes #1923
Member
Author
|
Your concern was valid to check, but our implementation handles it correctly. 👍 Some notes for future reference:
|
Member
Author
|
Huh, looks like the tests failed, but for an unrelated issue. We should move all tests to "example URLs" at some point and not depend on external servers. 😖 |
Member
Author
|
Okay, the test fixed itself. My favorite kind of fix. Merging. |
Member
|
Awesome I see no problems. That was really quick 🚀 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, each HTML line inside a Markdown file would be parsed independently. This worked reasonably well, but in the case where individual lines are not valid HTML, we would skip link checking.
The fix is to accumulate an HTML block until it gets closed and only then parsing it.
Fixes #1923