Config file up to date#1906
Merged
Merged
Conversation
This was referenced Nov 11, 2025
Merged
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Mar 5, 2026
Fixes the CI job https://github.com/open-telemetry/opentelemetry-collector/actions/runs/22696233513/job/65804104304 The changelog link checker CI started failing after open-telemetry#14676 bumped `lycheeverse/lychee-action` from v2.7.0 to v2.8.0, which bundles lychee v0.23.0. lycheeverse/lychee#1906 ("Config file up to date") made unknown TOML keys a hard error instead of silently ignoring them. The two keys in `.github/lychee.toml` used hyphens (`include-fragments`, `max-retries`), but the actual struct field names use underscores (`include_fragments`, `max_retries`). I'm disabling the options for now to keep the behavior as as. Will try to bring back fragments check after that. I assume they might fail
github-merge-queue Bot
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 5, 2026
Fixes the CI job https://github.com/open-telemetry/opentelemetry-collector/actions/runs/22696233513/job/65804104304 The changelog link checker CI started failing after #14676 bumped `lycheeverse/lychee-action` from v2.7.0 to v2.8.0, which bundles lychee v0.23.0. lycheeverse/lychee#1906 made unknown TOML keys a hard error instead of silently ignoring them. The two keys in `.github/lychee.toml` used hyphens (`include-fragments`, `max-retries`), but the actual struct field names use underscores (`include_fragments`, `max_retries`). I'm disabling the options for now to keep the behavior as is. Will try to actually introduce the fragments check after that. I assume they might fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following (also see commit history)
files_fromis now usable within the config fileAddresses #1768