Skip to content

Fix typos, and configure the typos tool#1895

Merged
thomas-zahner merged 3 commits into
lycheeverse:masterfrom
linkmauve:fix-typos
Oct 31, 2025
Merged

Fix typos, and configure the typos tool#1895
thomas-zahner merged 3 commits into
lycheeverse:masterfrom
linkmauve:fix-typos

Conversation

@linkmauve

Copy link
Copy Markdown
Contributor

typos is a nice tool which finds and fixes typos in a codebase.

@thomas-zahner

Copy link
Copy Markdown
Member

Thank you for the PR. I agree that this is a nice addition.
Can you also add a check to CI, potentially with the dedicated GitHub action? This way we won't miss new typos.

Also, I've just addressed the new linting issues on master. So by rebasing on master CI should pass again.

These were found thanks to the typos[1] tool.

[1] https://github.com/crate-ci/typos
This ignores the benches files, which are only used for benchmarking and
shouldn’t be checked for typos.
@linkmauve

linkmauve commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

Yay, the added CI job seems to work just fine! https://github.com/lycheeverse/lychee/actions/runs/18968249929/job/54169626137?pr=1895

I’ll remove the testing commit then.

Edit: wow, that job finishes in just four seconds, that’s fast!

Edit 2: #1897 fixes one small issue your clippy fix uncovered.

@thomas-zahner

thomas-zahner commented Oct 31, 2025

Copy link
Copy Markdown
Member

Really cool, thanks for the PR. And yes four seconds is surprisingly quick. :)
Also, did a quick test if all works like I would expect and it does. See https://github.com/thomas-zahner/lychee/actions/runs/18972333688/job/54182928624 (ah, just noticed you already did the same, thanks 👍 )

@thomas-zahner thomas-zahner merged commit ba6c226 into lycheeverse:master Oct 31, 2025
7 checks passed
@mre mre mentioned this pull request Oct 31, 2025
@linkmauve linkmauve deleted the fix-typos branch October 31, 2025 12:54
@mre mre mentioned this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants