Clippy 1.88#1749
Merged
Merged
Conversation
Merged
mre
reviewed
Jun 27, 2025
Comment on lines
-467
to
-472
| // TODO: This test is currently failing because we don't handle nested | ||
| // verbatim elements of the same type correctly. The first closing tag will | ||
| // lift the verbatim flag. This is a known issue and could be handled by | ||
| // keeping a stack of verbatim flags. | ||
| #[test] | ||
| #[ignore] |
Member
There was a problem hiding this comment.
Ah nice, so this no longer failing? Thanks for removing the #[ignore].
mre
reviewed
Jun 27, 2025
| } | ||
|
|
||
| #[test] | ||
| #[ignore] |
Member
|
Very good. Thanks for updating! |
Closed
Member
Author
|
Sure no problem 👍 |
This was referenced Jul 3, 2025
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline fails because of Rust 1.88 was released yesterday with new clippy suggestions.
The most interesting part of this PR is that I removed
#[ignore]from two tests as I noticed that they are actually passing. I assume it's because the issues were addressed in the meantime. Or is there a reason we should still ignore them?