[Fix] stringify: apply formatter to encoded key under strictNullHandling#554
Merged
Merged
Conversation
…Handling` Previously the null branch returned the raw `encoder(prefix, ...)` output (or raw `prefix`) without running it through `formatter`. With `format: 'RFC1738'` this caused keys containing spaces to serialize as `%20` in strict-null mode while the normal primitive path produced `+`, yielding inconsistent output for the same key. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Co-Authored-By: Jordan Harband <ljharb@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
ChALkeR
reviewed
Apr 24, 2026
ChALkeR
left a comment
Contributor
There was a problem hiding this comment.
Before the fix:
> require('qs').stringify({'a a':null,'a b':1},{format:'RFC1738',strictNullHandling:true})
'a%20a&a+b=1'
Had both %20 and +.
ChALkeR
reviewed
Apr 24, 2026
f04f3c4 to
e3062f7
Compare
ljharb
approved these changes
Apr 27, 2026
ljharb
left a comment
Owner
There was a problem hiding this comment.
added an extra assertion with the same input, with the opposite strictNullHandling option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the null branch returned the raw
encoder(prefix, ...)output (or rawprefix) without running it throughformatter. Withformat: 'RFC1738'this caused keys containing spaces to serialize as%20in strict-null mode while the normal primitive path produced+, yielding inconsistent output for the same key.