Conversation
9422f92 to
d08aea5
Compare
🦋 Changeset detectedLatest commit: 79a62d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d08aea5 to
346fee3
Compare
346fee3 to
037990e
Compare
louis-bompart
left a comment
There was a problem hiding this comment.
Random review/opinion on a couple points ;)
037990e to
6bad459
Compare
|
@louis-bompart I updated the PR as suggested. Thanks for the review. |
|
Sorry, I did not realize updating the Node.js version breaks the custom vm types. This only happens, if you delete the previously built files. |
6bad459 to
db8afef
Compare
|
@augustjk I have re-applied to changes the actual state of the main branch and resolved the |
db8afef to
e83749b
Compare
There was a problem hiding this comment.
@justinfagnani do you recall why we needed these custom types? maybe @types/node was lacking at the time, and it's safe to rely on that now.
There was a problem hiding this comment.
With @types/node <= 16, these types were not defined. With @types/node 18 they were incompatible. With @types/node >= 20 they seem to be obsolete.
|
The failing tests are timeouts. As the tests are successful locally, I assume a rerun should fix it. |
e83749b to
07464b7
Compare
…nt conflicts in consumer projects
07464b7 to
79a62d1
Compare
|
@augustjk Can I ask you to merge this? |
|
@augustjk Thank you very much! 😃 |
Currently the
@lit-labs/ssrpackage uses^16.0.0as the dependency version for@types/node. This causes npm or yarn install in consuming projects to complain about version incompatibility, if the project uses a newer major version.This PR changes the dependency to a peer dependency with a version range of
>=18.0.0 <25.0.0(18 being the oldest still supported LTS version).