Support @provide with experimental decorators on a property#4200
Merged
Conversation
It might feel like this is working at cross purposes to our standard decorators work, because those all require accessors, but I don't think so. With standard decorators we can use the type system to error out if they're used on a property instead of an accessor. With experimental decorators, they sorta work with properties, in that they do provide values and update them, but reading the value back off the field would always give undefined because we were defining it without a getter.
🦋 Changeset detectedLatest commit: 545e76c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
Contributor
|
The size of lit-html.js and lit-core.min.js are as expected. |
| assert.strictEqual(consumer.value, 500); | ||
| assert.strictEqual(consumer2.value, 1000); // one-time consumer still has old value | ||
| }); | ||
|
|
Collaborator
There was a problem hiding this comment.
I'm getting pretty confused where the tests go in the package these days. This suite didn't previously use any of the context decorators, and the thing you're testing isn't that providers and consumers work, but that the decorator works. This came up for me when I made the std-decorators tests too.
Could we make a decorators-specific test folder?
| }; | ||
| let newDescriptor; | ||
| if (descriptor === undefined) { | ||
| const symbol = Symbol(); |
Collaborator
There was a problem hiding this comment.
Use a more descriptive name like storage or key? Also, Russell added a nice dev-mode switch to @query() where there was a string description for the Symbol like @provide() storage key for ${nameOrContext} for debugging.
Collaborator
Author
There was a problem hiding this comment.
Switched to a WeakMap for consistency in this file
Comment on lines
+108
to
+110
| if (oldSetter) { | ||
| oldSetter.call(this, value); | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (oldSetter) { | |
| oldSetter.call(this, value); | |
| } | |
| oldSetter?.call(this, value); |
| this: ReactiveElement & {[symbol]: ValueType}, | ||
| value: ValueType | ||
| ) { | ||
| controllerMap.get(this)?.setValue(value); |
Collaborator
There was a problem hiding this comment.
This element will always be in the map by this point, so I don't think we need to optional chaining.
Collaborator
Author
There was a problem hiding this comment.
Switched to not-null assertion
This was referenced Sep 28, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might feel like this is working at cross purposes to our standard decorators work, because those all require accessors, but I don't think so. With standard decorators we can use the type system to error out if they're used on a property instead of an accessor. With experimental decorators, they sorta work with properties, in that they do provide values and update them, but reading the value back off the field would always give undefined because we were defining it without a getter.