Skip to content

Update every typescript to 5.2.0#4141

Merged
justinfagnani merged 4 commits into3.0from
3.0-update-typescript
Aug 25, 2023
Merged

Update every typescript to 5.2.0#4141
justinfagnani merged 4 commits into3.0from
3.0-update-typescript

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Aug 25, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 65ce155

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 43 packages
Name Type
@lit/ts-transformers Major
@lit/lit-starter-ts Major
@lit-labs/gen-wrapper-angular Minor
@lit-labs/gen-wrapper-react Minor
@lit-labs/gen-wrapper-vue Minor
@lit-labs/cli-localize Minor
@lit-labs/gen-manifest Minor
@lit-labs/gen-utils Minor
@lit/localize-tools Minor
@lit-labs/analyzer Minor
@lit-labs/compiler Minor
@lit-internal/test-element-a Patch
@lit-internal/localize-examples-transform-js Patch
@lit-internal/localize-examples-transform-ts Patch
@lit-internal/localize-examples-runtime-js Patch
@lit-internal/localize-examples-runtime-ts Patch
@lit-labs/scoped-registry-mixin Patch
@lit-labs/eleventy-plugin-lit Patch
@lit-labs/preact-signals Patch
@lit-labs/ssr-dom-shim Patch
@lit-internal/scripts Patch
@lit-labs/virtualizer Patch
@lit/reactive-element Patch
@lit-labs/ssr-client Patch
@lit-labs/observers Patch
@lit-labs/ssr-react Patch
@lit-labs/vue-utils Patch
@lit/lit-starter-js Patch
@lit-labs/context Patch
@lit-labs/testing Patch
@lit-labs/motion Patch
@lit-labs/nextjs Patch
@lit-labs/router Patch
lit-element Patch
@lit-internal/benchmarks Patch
@lit-labs/react Patch
@lit-labs/task Patch
@lit-labs/cli Patch
@lit-labs/ssr Patch
lit-html Patch
@lit/localize Patch
@lit-internal/tests Patch
lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +16% (-1.54ms - +3.12ms)
    this-change vs tip-of-tree

render

  • this-change: 68.58ms - 71.26ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +5% (-1.25ms - +1.48ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-1.07ms - +0.58ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +0% (-1.54ms - +0.16ms)
    this-change vs tip-of-tree

update

  • this-change: 666.04ms - 673.99ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +6% (-1.33ms - +4.23ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: faster ✔ 0% - 3% (0.01ms - 3.20ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-7.02ms - +2.27ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 633.21ms - 638.47ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +1% (-2.73ms - +3.52ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
68.58ms - 71.26ms-

update

VersionAvg timevs
666.04ms - 673.99ms-

update-reflect

VersionAvg timevs
633.21ms - 638.47ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
26.34ms - 28.29ms-unsure 🔍
-5% - +5%
-1.25ms - +1.48ms		unsure 🔍
-5% - +4%
-1.43ms - +1.15ms
tip-of-tree
tip-of-tree		26.24ms - 28.15msunsure 🔍
-5% - +5%
-1.48ms - +1.25ms		-unsure 🔍
-6% - +4%
-1.53ms - +1.01ms
previous-release
previous-release		26.61ms - 28.29msunsure 🔍
-4% - +5%
-1.15ms - +1.43ms		unsure 🔍
-4% - +6%
-1.01ms - +1.53ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
70.41ms - 73.83ms-unsure 🔍
-2% - +6%
-1.33ms - +4.23ms		unsure 🔍
-3% - +6%
-2.17ms - +4.26ms
tip-of-tree
tip-of-tree		68.47ms - 72.86msunsure 🔍
-6% - +2%
-4.23ms - +1.33ms		-unsure 🔍
-5% - +4%
-3.91ms - +3.09ms
previous-release
previous-release		68.35ms - 73.80msunsure 🔍
-6% - +3%
-4.26ms - +2.17ms		unsure 🔍
-4% - +6%
-3.09ms - +3.91ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
18.06ms - 21.81ms-unsure 🔍
-8% - +16%
-1.54ms - +3.12ms		unsure 🔍
-2% - +20%
-0.39ms - +3.63ms
tip-of-tree
tip-of-tree		17.77ms - 20.52msunsure 🔍
-15% - +7%
-3.12ms - +1.54ms		-unsure 🔍
-4% - +13%
-0.73ms - +2.39ms
previous-release
previous-release		17.58ms - 19.05msunsure 🔍
-18% - +1%
-3.63ms - +0.39ms		unsure 🔍
-12% - +4%
-2.39ms - +0.73ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
45.64ms - 46.89ms-unsure 🔍
-2% - +1%
-1.07ms - +0.58ms		unsure 🔍
-3% - +1%
-1.18ms - +0.54ms
tip-of-tree
tip-of-tree		45.97ms - 47.05msunsure 🔍
-1% - +2%
-0.58ms - +1.07ms		-unsure 🔍
-2% - +2%
-0.87ms - +0.72ms
previous-release
previous-release		46.00ms - 47.17msunsure 🔍
-1% - +3%
-0.54ms - +1.18ms		unsure 🔍
-2% - +2%
-0.72ms - +0.87ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
96.13ms - 97.99ms-faster ✔
0% - 3%
0.01ms - 3.20ms		unsure 🔍
-2% - +0%
-2.42ms - +0.32ms
tip-of-tree
tip-of-tree		97.37ms - 99.95msslower ❌
0% - 3%
0.01ms - 3.20ms		-unsure 🔍
-1% - +2%
-1.08ms - +2.19ms
previous-release
previous-release		97.11ms - 99.11msunsure 🔍
-0% - +3%
-0.32ms - +2.42ms		unsure 🔍
-2% - +1%
-2.19ms - +1.08ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
41.07ms - 42.32ms-unsure 🔍
-4% - +0%
-1.54ms - +0.16ms		unsure 🔍
-3% - +1%
-1.13ms - +0.53ms
tip-of-tree
tip-of-tree		41.80ms - 42.96msunsure 🔍
-0% - +4%
-0.16ms - +1.54ms		-unsure 🔍
-1% - +3%
-0.40ms - +1.19ms
previous-release
previous-release		41.45ms - 42.53msunsure 🔍
-1% - +3%
-0.53ms - +1.13ms		unsure 🔍
-3% - +1%
-1.19ms - +0.40ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
642.47ms - 649.29ms-unsure 🔍
-1% - +0%
-7.02ms - +2.27ms		unsure 🔍
-1% - +0%
-6.23ms - +2.85ms
tip-of-tree
tip-of-tree		645.11ms - 651.41msunsure 🔍
-0% - +1%
-2.27ms - +7.02ms		-unsure 🔍
-1% - +1%
-3.66ms - +5.03ms
previous-release
previous-release		644.58ms - 650.57msunsure 🔍
-0% - +1%
-2.85ms - +6.23ms		unsure 🔍
-1% - +1%
-5.03ms - +3.66ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
645.24ms - 649.79ms-unsure 🔍
-0% - +1%
-2.73ms - +3.52ms		unsure 🔍
-0% - +1%
-2.49ms - +4.45ms
tip-of-tree
tip-of-tree		644.98ms - 649.26msunsure 🔍
-1% - +0%
-3.52ms - +2.73ms		-unsure 🔍
-0% - +1%
-2.81ms - +3.97ms
previous-release
previous-release		643.92ms - 649.16msunsure 🔍
-1% - +0%
-4.45ms - +2.49ms		unsure 🔍
-1% - +0%
-3.97ms - +2.81ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

The size of lit-html.js and lit-core.min.js are as expected.

augustjk
augustjk approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

AndrewJakubowicz
AndrewJakubowicz requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update vue-tsc to 1.8.8 (from 0.29.8). That fixes npm run test from within packages/labs/gen-wrapper-vue.

That seems to fix the build error that is blocking CI (hopefully). Ah, it seems TS 5.0 support was added/fixed in 1.3.10.

@justinfagnani
Copy link
Collaborator Author

justinfagnani commented Aug 25, 2023

@AndrewJakubowicz I did update vue-tsc to 1.8.8 and still got the error

AndrewJakubowicz
AndrewJakubowicz approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@justinfagnani justinfagnani merged commit 6b515e4 into 3.0 Aug 25, 2023
@justinfagnani justinfagnani deleted the 3.0-update-typescript branch August 25, 2023 21:48
This was referenced Sep 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@augustjk augustjk augustjk approved these changes

@rictic rictic Awaiting requested review from rictic

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfagnani @AndrewJakubowicz @augustjk