Skip to content

Rename ReactiveElement._initialize to __initialize#4031

Merged
justinfagnani merged 1 commit intomainfrom
rename-initialize
Jul 19, 2023
Merged

Rename ReactiveElement._initialize to __initialize#4031
justinfagnani merged 1 commit intomainfrom
rename-initialize

Conversation

@justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Jul 19, 2023

Rename ReactiveElement._initialize to __initialize, make it private, and remove the @internal annotation. This will help prevent collisions with subclasses that implement their own _initialize method, while using development builds.

Thanks for @thepassle for enabling the development export condition by default in Web Dev Server, which highlighted this issue!

@justinfagnani justinfagnani requested a review from rictic July 19, 2023 17:31
@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

🦋 Changeset detected

Latest commit: 4515961

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@lit/reactive-element Patch
lit Patch
lit-element Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -8% - +25% (-1.97ms - +6.69ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 80.77ms - 84.45ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +16% (-1.88ms - +6.01ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +4% (-0.46ms - +0.46ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +5% (-1.70ms - +2.78ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +1% (-2.29ms - +0.34ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 921.46ms - 934.48ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +10% (-5.95ms - +10.16ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +5% (-5.25ms - +18.24ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-3.74ms - +2.64ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-12.83ms - +14.29ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 866.53ms - 882.34ms
  • reactive-element-list: unsure 🔍 -2% - +1% (-17.61ms - +9.65ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
80.77ms - 84.45ms-

update

VersionAvg timevs
921.46ms - 934.48ms-

update-reflect

VersionAvg timevs
866.53ms - 882.34ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.61ms - 43.52ms-unsure 🔍
-5% - +16%
-1.88ms - +6.01ms		unsure 🔍
-4% - +18%
-1.21ms - +6.73ms
tip-of-tree
tip-of-tree		35.89ms - 41.12msunsure 🔍
-15% - +4%
-6.01ms - +1.88ms		-unsure 🔍
-8% - +12%
-3.02ms - +4.42ms
previous-release
previous-release		35.15ms - 40.45msunsure 🔍
-16% - +3%
-6.73ms - +1.21ms		unsure 🔍
-11% - +8%
-4.42ms - +3.02ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
97.20ms - 110.35ms-unsure 🔍
-6% - +10%
-5.95ms - +10.16ms		unsure 🔍
-6% - +11%
-6.17ms - +10.99ms
tip-of-tree
tip-of-tree		97.02ms - 106.32msunsure 🔍
-10% - +6%
-10.16ms - +5.95ms		-unsure 🔍
-7% - +7%
-6.91ms - +7.52ms
previous-release
previous-release		95.85ms - 106.88msunsure 🔍
-10% - +6%
-10.99ms - +6.17ms		unsure 🔍
-7% - +7%
-7.52ms - +6.91ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
26.66ms - 33.43ms-unsure 🔍
-8% - +25%
-1.97ms - +6.69ms		unsure 🔍
-12% - +18%
-3.56ms - +5.21ms
tip-of-tree
tip-of-tree		24.98ms - 30.39msunsure 🔍
-22% - +6%
-6.69ms - +1.97ms		-unsure 🔍
-18% - +8%
-5.42ms - +2.35ms
previous-release
previous-release		26.43ms - 32.01msunsure 🔍
-17% - +12%
-5.21ms - +3.56ms		unsure 🔍
-9% - +20%
-2.35ms - +5.42ms		-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.19ms - 11.81ms-unsure 🔍
-4% - +4%
-0.46ms - +0.46ms		unsure 🔍
-4% - +3%
-0.45ms - +0.35ms
tip-of-tree
tip-of-tree		11.16ms - 11.83msunsure 🔍
-4% - +4%
-0.46ms - +0.46ms		-unsure 🔍
-4% - +3%
-0.48ms - +0.37ms
previous-release
previous-release		11.29ms - 11.81msunsure 🔍
-3% - +4%
-0.35ms - +0.45ms		unsure 🔍
-3% - +4%
-0.37ms - +0.48ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
349.99ms - 366.41ms-unsure 🔍
-2% - +5%
-5.25ms - +18.24ms		unsure 🔍
-1% - +5%
-5.12ms - +18.06ms
tip-of-tree
tip-of-tree		343.30ms - 360.10msunsure 🔍
-5% - +1%
-18.24ms - +5.25ms		-unsure 🔍
-3% - +3%
-11.75ms - +11.70ms
previous-release
previous-release		343.54ms - 359.90msunsure 🔍
-5% - +1%
-18.06ms - +5.12ms		unsure 🔍
-3% - +3%
-11.70ms - +11.75ms		-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
60.09ms - 63.89ms-unsure 🔍
-3% - +5%
-1.70ms - +2.78ms		unsure 🔍
-2% - +6%
-0.91ms - +3.43ms
tip-of-tree
tip-of-tree		60.26ms - 62.64msunsure 🔍
-4% - +3%
-2.78ms - +1.70ms		-unsure 🔍
-1% - +4%
-0.86ms - +2.30ms
previous-release
previous-release		59.68ms - 61.77msunsure 🔍
-5% - +1%
-3.43ms - +0.91ms		unsure 🔍
-4% - +1%
-2.30ms - +0.86ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
132.67ms - 136.94ms-unsure 🔍
-3% - +2%
-3.74ms - +2.64ms		unsure 🔍
-3% - +1%
-4.65ms - +1.57ms
tip-of-tree
tip-of-tree		132.99ms - 137.72msunsure 🔍
-2% - +3%
-2.64ms - +3.74ms		-unsure 🔍
-3% - +2%
-4.27ms - +2.28ms
previous-release
previous-release		134.08ms - 138.61msunsure 🔍
-1% - +3%
-1.57ms - +4.65ms		unsure 🔍
-2% - +3%
-2.28ms - +4.27ms		-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
50.45ms - 51.91ms-unsure 🔍
-4% - +1%
-2.29ms - +0.34ms		unsure 🔍
-2% - +2%
-1.11ms - +0.92ms
tip-of-tree
tip-of-tree		51.06ms - 53.25msunsure 🔍
-1% - +4%
-0.34ms - +2.29ms		-unsure 🔍
-1% - +4%
-0.42ms - +2.18ms
previous-release
previous-release		50.57ms - 51.98msunsure 🔍
-2% - +2%
-0.92ms - +1.11ms		unsure 🔍
-4% - +1%
-2.18ms - +0.42ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
945.59ms - 963.83ms-unsure 🔍
-1% - +1%
-12.83ms - +14.29ms		unsure 🔍
-1% - +2%
-10.51ms - +15.64ms
tip-of-tree
tip-of-tree		943.94ms - 964.01msunsure 🔍
-1% - +1%
-14.29ms - +12.83ms		-unsure 🔍
-1% - +2%
-11.89ms - +15.56ms
previous-release
previous-release		942.77ms - 961.51msunsure 🔍
-2% - +1%
-15.64ms - +10.51ms		unsure 🔍
-2% - +1%
-15.56ms - +11.89ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
912.25ms - 930.28ms-unsure 🔍
-2% - +1%
-17.61ms - +9.65ms		unsure 🔍
-1% - +1%
-10.25ms - +13.69ms
tip-of-tree
tip-of-tree		915.02ms - 935.47msunsure 🔍
-1% - +2%
-9.65ms - +17.61ms		-unsure 🔍
-1% - +2%
-7.21ms - +18.61ms
previous-release
previous-release		911.67ms - 927.42msunsure 🔍
-1% - +1%
-13.69ms - +10.25ms		unsure 🔍
-2% - +1%
-18.61ms - +7.21ms		-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani enabled auto-merge (squash) July 19, 2023 17:36
@justinfagnani justinfagnani merged commit 8057c78 into main Jul 19, 2023
@justinfagnani justinfagnani deleted the rename-initialize branch July 19, 2023 17:53
@bearfriend bearfriend mentioned this pull request Jul 22, 2023
Merged
@lit-robot lit-robot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinfagnani @rictic