Remove deprecated arguments and logic of queryAssignedNodes decoreator by AndrewJakubowicz · Pull Request #3850 · lit/lit

AndrewJakubowicz · 2023-04-26T22:54:38Z

Remove deprecated usage of queryAssignedNodes which is essentially a proxy for queryAssignedElements for Lit 3.0

Remove deprecated usage of queryAssignedNodes which is essentially a proxy for `queryAssignedElements`.

changeset-bot · 2023-04-26T22:54:40Z

🦋 Changeset detected

Latest commit: 2581ca3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@lit/ts-transformers	Major
@lit/reactive-element	Major
@lit/localize-tools	Patch
@lit-internal/benchmarks	Patch
lit-element	Patch
lit	Patch
@lit/localize	Patch
@lit-labs/context	Patch
@lit-labs/observers	Patch
@lit-labs/scoped-registry-mixin	Patch
@lit-labs/ssr-client	Patch
@lit-labs/ssr	Patch
@lit-labs/task	Patch
@lit/lit-starter-js	Patch
@lit/lit-starter-ts	Patch
@lit-labs/eleventy-plugin-lit	Patch
@lit-labs/motion	Patch
@lit-labs/router	Patch
@lit-labs/ssr-react	Patch
@lit-labs/testing	Patch
@lit-labs/virtualizer	Patch
@lit-internal/test-element-a	Patch
@lit-internal/localize-examples-runtime-js	Patch
@lit-internal/localize-examples-runtime-ts	Patch
@lit-internal/localize-examples-transform-js	Patch
@lit-internal/localize-examples-transform-ts	Patch
@lit-labs/cli-localize	Patch
@lit-labs/cli	Patch
@lit-labs/nextjs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-04-26T22:55:05Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -6% - +3% (-1.21ms - +0.63ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 88.29ms - 94.37ms
lit-html-kitchen-sink: unsure 🔍 -8% - +2% (-3.30ms - +0.88ms)
^{this-change vs tip-of-tree}
lit-html-repeat: faster ✔ 0% - 8% (0.05ms - 1.06ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +3% (-2.23ms - +1.73ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -6% - +3% (-3.63ms - +1.54ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 911.46ms - 930.98ms
lit-html-kitchen-sink: unsure 🔍 -4% - +8% (-3.17ms - +7.65ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +3% (-6.24ms - +10.28ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +2% (-2.99ms - +2.42ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-10.44ms - +12.68ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 877.52ms - 896.30ms
reactive-element-list: unsure 🔍 -1% - +1% (-13.11ms - +13.55ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4712
Commit: 7992d2e

render

Version	Avg time	vs
	88.29ms - 94.37ms	-

update

Version	Avg time	vs
	911.46ms - 930.98ms	-

update-reflect

Version	Avg time	vs
	877.52ms - 896.30ms	-

lit-html-kitchen-sink

Browser: chrome-headless 112.0.5615.165
Sample size: 30
Built by: Benchmarks #4712
Commit: 7992d2e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	36.27ms - 39.03ms	-	unsure 🔍 -8% - +2% -3.30ms - +0.88ms	unsure 🔍 -8% - +4% -2.91ms - +1.43ms
tip-of-tree tip-of-tree	37.28ms - 40.44ms	unsure 🔍 -2% - +9% -0.88ms - +3.30ms	-	unsure 🔍 -5% - +7% -1.83ms - +2.77ms
previous-release previous-release	36.72ms - 40.06ms	unsure 🔍 -4% - +8% -1.43ms - +2.91ms	unsure 🔍 -7% - +5% -2.77ms - +1.83ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	90.70ms - 97.32ms	-	unsure 🔍 -4% - +8% -3.17ms - +7.65ms	unsure 🔍 -7% - +4% -6.88ms - +3.93ms
tip-of-tree tip-of-tree	87.49ms - 96.05ms	unsure 🔍 -8% - +3% -7.65ms - +3.17ms	-	unsure 🔍 -10% - +2% -9.76ms - +2.33ms
previous-release previous-release	91.21ms - 99.76ms	unsure 🔍 -4% - +7% -3.93ms - +6.88ms	unsure 🔍 -3% - +11% -2.33ms - +9.76ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.73ms - 19.67ms	-	unsure 🔍 -6% - +3% -1.21ms - +0.63ms	unsure 🔍 -11% - +4% -2.20ms - +0.85ms
tip-of-tree tip-of-tree	18.70ms - 20.28ms	unsure 🔍 -3% - +6% -0.63ms - +1.21ms	-	unsure 🔍 -10% - +6% -2.04ms - +1.27ms
previous-release previous-release	18.42ms - 21.33ms	unsure 🔍 -4% - +11% -0.85ms - +2.20ms	unsure 🔍 -7% - +11% -1.27ms - +2.04ms	-

lit-html-repeat

Browser: chrome-headless 112.0.5615.165
Sample size: 30
Built by: Benchmarks #4712
Commit: 7992d2e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.77ms - 12.59ms	-	faster ✔ 0% - 8% 0.05ms - 1.06ms	faster ✔ 2% - 12% 0.21ms - 1.58ms
tip-of-tree tip-of-tree	12.44ms - 13.02ms	slower ❌ 0% - 9% 0.05ms - 1.06ms	-	unsure 🔍 -7% - +2% -0.96ms - +0.28ms
previous-release previous-release	12.52ms - 13.62ms	slower ❌ 2% - 13% 0.21ms - 1.58ms	unsure 🔍 -2% - +8% -0.28ms - +0.96ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	342.27ms - 353.72ms	-	unsure 🔍 -2% - +3% -6.24ms - +10.28ms	unsure 🔍 -2% - +3% -7.72ms - +8.72ms
tip-of-tree tip-of-tree	340.02ms - 351.92ms	unsure 🔍 -3% - +2% -10.28ms - +6.24ms	-	unsure 🔍 -3% - +2% -9.90ms - +6.86ms
previous-release previous-release	341.60ms - 353.39ms	unsure 🔍 -3% - +2% -8.72ms - +7.72ms	unsure 🔍 -2% - +3% -6.86ms - +9.90ms	-

lit-html-template-heavy

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4712
Commit: 7992d2e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	66.27ms - 68.85ms	-	unsure 🔍 -3% - +3% -2.23ms - +1.73ms	unsure 🔍 -3% - +3% -2.24ms - +1.81ms
tip-of-tree tip-of-tree	66.30ms - 69.31ms	unsure 🔍 -3% - +3% -1.73ms - +2.23ms	-	unsure 🔍 -3% - +3% -2.13ms - +2.21ms
previous-release previous-release	66.21ms - 69.34ms	unsure 🔍 -3% - +3% -1.81ms - +2.24ms	unsure 🔍 -3% - +3% -2.21ms - +2.13ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	130.64ms - 134.69ms	-	unsure 🔍 -2% - +2% -2.99ms - +2.42ms	unsure 🔍 -3% - +2% -4.30ms - +2.17ms
tip-of-tree tip-of-tree	131.16ms - 134.74ms	unsure 🔍 -2% - +2% -2.42ms - +2.99ms	-	unsure 🔍 -3% - +2% -3.87ms - +2.31ms
previous-release previous-release	131.21ms - 136.25ms	unsure 🔍 -2% - +3% -2.17ms - +4.30ms	unsure 🔍 -2% - +3% -2.31ms - +3.87ms	-

reactive-element-list

Browser: chrome-headless 112.0.5615.165
Sample size: 50
Built by: Benchmarks #4712
Commit: 7992d2e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	57.56ms - 61.16ms	-	unsure 🔍 -6% - +3% -3.63ms - +1.54ms	unsure 🔍 -5% - +3% -2.88ms - +2.02ms
tip-of-tree tip-of-tree	58.54ms - 62.26ms	unsure 🔍 -3% - +6% -1.54ms - +3.63ms	-	unsure 🔍 -3% - +5% -1.88ms - +3.11ms
previous-release previous-release	58.13ms - 61.45ms	unsure 🔍 -3% - +5% -2.02ms - +2.88ms	unsure 🔍 -5% - +3% -3.11ms - +1.88ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	929.47ms - 946.64ms	-	unsure 🔍 -1% - +1% -10.44ms - +12.68ms	unsure 🔍 -1% - +1% -9.29ms - +13.48ms
tip-of-tree tip-of-tree	929.20ms - 944.67ms	unsure 🔍 -1% - +1% -12.68ms - +10.44ms	-	unsure 🔍 -1% - +1% -9.78ms - +11.73ms
previous-release previous-release	928.49ms - 943.43ms	unsure 🔍 -1% - +1% -13.48ms - +9.29ms	unsure 🔍 -1% - +1% -11.73ms - +9.78ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	923.49ms - 943.13ms	-	unsure 🔍 -1% - +1% -13.11ms - +13.55ms	unsure 🔍 -1% - +1% -11.64ms - +13.56ms
tip-of-tree tip-of-tree	924.07ms - 942.11ms	unsure 🔍 -1% - +1% -13.55ms - +13.11ms	-	unsure 🔍 -1% - +1% -11.25ms - +12.72ms
previous-release previous-release	924.45ms - 940.25ms	unsure 🔍 -1% - +1% -13.56ms - +11.64ms	unsure 🔍 -1% - +1% -12.72ms - +11.25ms	-

_{tachometer-reporter-action v2 for Benchmarks}

AndrewJakubowicz · 2023-04-26T23:48:21Z

Tests were failing because the removed API was expected in the ts-transformer tests. I've now removed deprecated API from the transformer as well.

Re-requesting review from @justinfagnani

packages/reactive-element/src/decorators/query-assigned-nodes.ts

Remove deprecated arguments to queryAssignedNodes

3c0e6e9

Remove deprecated usage of queryAssignedNodes which is essentially a proxy for `queryAssignedElements`.

AndrewJakubowicz requested a review from justinfagnani as a code owner April 26, 2023 22:54

justinfagnani added the 3.0 label Apr 26, 2023

Add changeset

5e1c7a1

AndrewJakubowicz requested a review from augustjk April 26, 2023 22:59

justinfagnani approved these changes Apr 26, 2023

View reviewed changes

AndrewJakubowicz added 3 commits April 26, 2023 16:44

Remove transform of legacy queryAssignedNodes usage.

500be79

ts-transformers changeset

d77e9ae

Merge branch '3.0' into remove-deprecated-query-assigned-nodes

cab45c2

AndrewJakubowicz requested a review from justinfagnani April 26, 2023 23:47

justinfagnani approved these changes Apr 26, 2023

View reviewed changes

Small test fix with string quotes.

306ebd2

augustjk reviewed Apr 27, 2023

View reviewed changes

packages/reactive-element/src/decorators/query-assigned-nodes.ts Outdated Show resolved Hide resolved

Code review feedback - remove interface.

2581ca3

augustjk approved these changes Apr 27, 2023

View reviewed changes

AndrewJakubowicz merged commit 7e8491d into 3.0 Apr 27, 2023

AndrewJakubowicz deleted the remove-deprecated-query-assigned-nodes branch April 27, 2023 06:33

lit-robot mentioned this pull request Apr 27, 2023

Version Packages (pre) #3853

Merged

Conversation

AndrewJakubowicz commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

AndrewJakubowicz commented Apr 26, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AndrewJakubowicz commented Apr 26, 2023 •

edited

Loading

changeset-bot bot commented Apr 26, 2023 •

edited

Loading

github-actions bot commented Apr 26, 2023 •

edited

Loading