Update to TypeScript 5.0 by rictic · Pull Request #3814 · lit/lit

rictic · 2023-04-18T21:57:01Z

No description provided.

changeset-bot · 2023-04-18T21:57:04Z

🦋 Changeset detected

Latest commit: 3cc507d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages

Name	Type
@lit/ts-transformers	Major
@lit/localize-tools	Minor
@lit-internal/test-element-a	Patch
@lit-internal/localize-examples-transform-js	Patch
@lit-internal/localize-examples-transform-ts	Patch
@lit-internal/localize-examples-runtime-ts	Patch
@lit-labs/scoped-registry-mixin	Patch
@lit-labs/eleventy-plugin-lit	Patch
@lit-labs/gen-wrapper-angular	Patch
@lit-labs/gen-wrapper-react	Patch
@lit-labs/gen-wrapper-vue	Patch
@lit-labs/cli-localize	Patch
@lit-labs/gen-manifest	Patch
@lit-labs/ssr-dom-shim	Patch
@lit-internal/scripts	Patch
@lit-labs/virtualizer	Patch
@lit/reactive-element	Patch
@lit-labs/ssr-client	Patch
@lit-labs/gen-utils	Patch
@lit-labs/observers	Patch
@lit-labs/ssr-react	Patch
@lit-labs/vue-utils	Patch
@lit/lit-starter-js	Patch
@lit/lit-starter-ts	Patch
@lit-labs/analyzer	Patch
@lit-labs/context	Patch
@lit-labs/testing	Patch
@lit-labs/motion	Patch
@lit-labs/nextjs	Patch
@lit-labs/router	Patch
lit-element	Patch
@lit-internal/benchmarks	Patch
@lit-labs/react	Patch
@lit-labs/task	Patch
@lit-labs/cli	Patch
@lit-labs/ssr	Patch
lit-html	Patch
@lit/localize	Patch
@lit-internal/tests	Patch
lit	Patch
@lit-internal/localize-examples-runtime-js	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-04-18T21:57:25Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +5% (-0.58ms - +0.94ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 87.52ms - 93.17ms
lit-html-kitchen-sink: unsure 🔍 -7% - +5% (-2.60ms - +2.07ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -6% - +2% (-0.72ms - +0.24ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +3% (-1.43ms - +2.22ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -7% - +0% (-4.30ms - +0.18ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 921.37ms - 932.54ms
lit-html-kitchen-sink: unsure 🔍 -4% - +6% (-3.51ms - +5.64ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +3% (-2.57ms - +11.30ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +1% (-2.70ms - +1.68ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-6.96ms - +6.83ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 889.82ms - 899.99ms
reactive-element-list: unsure 🔍 -1% - +0% (-8.06ms - +4.20ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 112.0.5615.49
Sample size: 50
Built by: Benchmarks #4660
Commit: d961ea0

render

Version	Avg time	vs
	87.52ms - 93.17ms	-

update

Version	Avg time	vs
	921.37ms - 932.54ms	-

update-reflect

Version	Avg time	vs
	889.82ms - 899.99ms	-

lit-html-kitchen-sink

Browser: chrome-headless 112.0.5615.49
Sample size: 30
Built by: Benchmarks #4660
Commit: d961ea0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	37.62ms - 40.78ms	-	unsure 🔍 -7% - +5% -2.60ms - +2.07ms	unsure 🔍 -3% - +8% -1.17ms - +3.15ms
tip-of-tree tip-of-tree	37.75ms - 41.19ms	unsure 🔍 -5% - +7% -2.07ms - +2.60ms	-	unsure 🔍 -3% - +9% -1.00ms - +3.52ms
previous-release previous-release	36.74ms - 39.67ms	unsure 🔍 -8% - +3% -3.15ms - +1.17ms	unsure 🔍 -9% - +2% -3.52ms - +1.00ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	93.73ms - 100.90ms	-	unsure 🔍 -4% - +6% -3.51ms - +5.64ms	unsure 🔍 -4% - +6% -3.90ms - +5.38ms
tip-of-tree tip-of-tree	93.42ms - 99.09ms	unsure 🔍 -6% - +4% -5.64ms - +3.51ms	-	unsure 🔍 -5% - +4% -4.40ms - +3.76ms
previous-release previous-release	93.64ms - 99.51ms	unsure 🔍 -6% - +4% -5.38ms - +3.90ms	unsure 🔍 -4% - +5% -3.76ms - +4.40ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	18.47ms - 19.67ms	-	unsure 🔍 -3% - +5% -0.58ms - +0.94ms	unsure 🔍 -4% - +5% -0.82ms - +0.86ms
tip-of-tree tip-of-tree	18.42ms - 19.36ms	unsure 🔍 -5% - +3% -0.94ms - +0.58ms	-	unsure 🔍 -5% - +3% -0.91ms - +0.60ms
previous-release previous-release	18.46ms - 19.64ms	unsure 🔍 -5% - +4% -0.86ms - +0.82ms	unsure 🔍 -3% - +5% -0.60ms - +0.91ms	-

lit-html-repeat

Browser: chrome-headless 112.0.5615.49
Sample size: 30
Built by: Benchmarks #4660
Commit: d961ea0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.84ms - 12.44ms	-	unsure 🔍 -6% - +2% -0.72ms - +0.24ms	unsure 🔍 -11% - +3% -1.36ms - +0.42ms
tip-of-tree tip-of-tree	12.00ms - 12.75ms	unsure 🔍 -2% - +6% -0.24ms - +0.72ms	-	unsure 🔍 -9% - +5% -1.16ms - +0.68ms
previous-release previous-release	11.77ms - 13.45ms	unsure 🔍 -3% - +11% -0.42ms - +1.36ms	unsure 🔍 -6% - +9% -0.68ms - +1.16ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	340.66ms - 351.40ms	-	unsure 🔍 -1% - +3% -2.57ms - +11.30ms	unsure 🔍 -1% - +4% -3.69ms - +12.05ms
tip-of-tree tip-of-tree	337.27ms - 346.05ms	unsure 🔍 -3% - +1% -11.30ms - +2.57ms	-	unsure 🔍 -2% - +2% -7.42ms - +7.05ms
previous-release previous-release	336.09ms - 347.60ms	unsure 🔍 -3% - +1% -12.05ms - +3.69ms	unsure 🔍 -2% - +2% -7.05ms - +7.42ms	-

lit-html-template-heavy

Browser: chrome-headless 112.0.5615.49
Sample size: 50
Built by: Benchmarks #4660
Commit: d961ea0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.29ms - 68.08ms	-	unsure 🔍 -2% - +3% -1.43ms - +2.22ms	unsure 🔍 -2% - +3% -1.49ms - +2.10ms
tip-of-tree tip-of-tree	65.11ms - 67.46ms	unsure 🔍 -3% - +2% -2.22ms - +1.43ms	-	unsure 🔍 -3% - +2% -1.73ms - +1.54ms
previous-release previous-release	65.24ms - 67.52ms	unsure 🔍 -3% - +2% -2.10ms - +1.49ms	unsure 🔍 -2% - +3% -1.54ms - +1.73ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	137.19ms - 139.82ms	-	unsure 🔍 -2% - +1% -2.70ms - +1.68ms	unsure 🔍 -3% - +1% -3.61ms - +1.69ms
tip-of-tree tip-of-tree	137.26ms - 140.77ms	unsure 🔍 -1% - +2% -1.68ms - +2.70ms	-	unsure 🔍 -2% - +2% -3.35ms - +2.44ms
previous-release previous-release	137.16ms - 141.77ms	unsure 🔍 -1% - +3% -1.69ms - +3.61ms	unsure 🔍 -2% - +2% -2.44ms - +3.35ms	-

reactive-element-list

Browser: chrome-headless 112.0.5615.49
Sample size: 50
Built by: Benchmarks #4660
Commit: d961ea0

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	59.59ms - 61.86ms	-	unsure 🔍 -7% - +0% -4.30ms - +0.18ms	unsure 🔍 -5% - +1% -3.06ms - +0.91ms
tip-of-tree tip-of-tree	60.85ms - 64.72ms	unsure 🔍 -0% - +7% -0.18ms - +4.30ms	-	unsure 🔍 -3% - +6% -1.54ms - +3.51ms
previous-release previous-release	60.17ms - 63.43ms	unsure 🔍 -2% - +5% -0.91ms - +3.06ms	unsure 🔍 -6% - +2% -3.51ms - +1.54ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	961.58ms - 970.89ms	-	unsure 🔍 -1% - +1% -6.96ms - +6.83ms	unsure 🔍 -1% - +1% -7.76ms - +7.07ms
tip-of-tree tip-of-tree	961.21ms - 971.39ms	unsure 🔍 -1% - +1% -6.83ms - +6.96ms	-	unsure 🔍 -1% - +1% -7.97ms - +7.42ms
previous-release previous-release	960.81ms - 972.35ms	unsure 🔍 -1% - +1% -7.07ms - +7.76ms	unsure 🔍 -1% - +1% -7.42ms - +7.97ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	946.60ms - 955.80ms	-	unsure 🔍 -1% - +0% -8.06ms - +4.20ms	unsure 🔍 -1% - +0% -10.41ms - +3.61ms
tip-of-tree tip-of-tree	949.07ms - 957.19ms	unsure 🔍 -0% - +1% -4.20ms - +8.06ms	-	unsure 🔍 -1% - +1% -8.14ms - +5.19ms
previous-release previous-release	949.31ms - 959.89ms	unsure 🔍 -0% - +1% -3.61ms - +10.41ms	unsure 🔍 -1% - +1% -5.19ms - +8.14ms	-

_{tachometer-reporter-action v2 for Benchmarks}

rictic · 2023-04-19T00:03:45Z

.d.ts changes look chill: https://gist.github.com/rictic/1ddd4afd56b88f008609d05f05e4ce80

package.json

packages/labs/context/package.json

packages/localize-tools/src/modes/transform.ts

packages/ts-transformers/package.json

First part of conversion to TS 5.0

4c3d66b

rictic requested review from benjamind and justinfagnani as code owners April 18, 2023 21:57

rictic added 3 commits April 18, 2023 15:45

Minor fixes

29f303c

Changeset

7c64117

Remove unnecessary dep

ec81331

Fix another compiler error.

8acc4b7

justinfagnani reviewed Apr 19, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

packages/labs/context/package.json Outdated Show resolved Hide resolved

packages/localize-tools/src/modes/transform.ts Show resolved Hide resolved

packages/ts-transformers/package.json Show resolved Hide resolved

rictic added 3 commits April 19, 2023 16:18

Do a breaking change bump to localize-tools and ts-transformers.

7dbbb92

Standardize on a single version for @esm-bundle/chai

9d22756

Uninstall chai

3cc507d

rictic requested a review from justinfagnani April 19, 2023 23:31

justinfagnani approved these changes Apr 19, 2023

View reviewed changes

rictic merged commit 23326c6 into 3.0 Apr 20, 2023

rictic deleted the ts5 branch April 20, 2023 00:27

This was referenced Apr 26, 2023

Version Packages (3.0) #3846

Closed

Version Packages (pre) #3853

Merged

Conversation

rictic commented Apr 18, 2023

Uh oh!

changeset-bot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

rictic commented Apr 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Apr 18, 2023 •

edited

Loading

github-actions bot commented Apr 18, 2023 •

edited

Loading