[all] Drop IE11 support by justinfagnani · Pull Request #3756 · lit/lit

justinfagnani · 2023-03-24T02:31:45Z

Removes the IE runner and sauce configs
Removes IE example configs in starter kits

changeset-bot · 2023-03-24T02:31:48Z

🦋 Changeset detected

Latest commit: 48a9bed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@lit/lit-starter-js	Major
@lit/lit-starter-ts	Major
lit-html	Major
lit	Major
lit-element	Major
@lit/reactive-element	Major
@lit-internal/benchmarks	Patch
@lit-labs/ssr-client	Patch
@lit-labs/ssr	Patch
@lit/localize-tools	Patch
@lit/localize	Patch
@lit-labs/context	Patch
@lit-labs/eleventy-plugin-lit	Patch
@lit-labs/motion	Patch
@lit-labs/router	Patch
@lit-labs/scoped-registry-mixin	Patch
@lit-labs/ssr-react	Patch
@lit-labs/testing	Patch
@lit-labs/virtualizer	Patch
@lit-internal/test-element-a	Patch
@lit-internal/localize-examples-runtime-js	Patch
@lit-internal/localize-examples-runtime-ts	Patch
@lit-internal/localize-examples-transform-js	Patch
@lit-internal/localize-examples-transform-ts	Patch
@lit-labs/observers	Patch
@lit-labs/task	Patch
@lit-labs/cli-localize	Patch
@lit-labs/cli	Patch
@lit-labs/nextjs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-03-24T02:32:12Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -7% - +5% (-1.36ms - +1.02ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 103.05ms - 108.35ms
lit-html-kitchen-sink: unsure 🔍 -7% - +7% (-2.96ms - +3.05ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -7% - +12% (-1.04ms - +1.73ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +5% (-1.23ms - +3.56ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -5% - +1% (-3.38ms - +0.87ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 1107.50ms - 1125.64ms
lit-html-kitchen-sink: unsure 🔍 -3% - +5% (-3.13ms - +5.27ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -9% - +10% (-31.49ms - +36.63ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +4% (-3.53ms - +6.84ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-12.62ms - +18.22ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 1073.83ms - 1093.94ms
reactive-element-list: unsure 🔍 -1% - +2% (-12.33ms - +18.00ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 111.0.5563.64
Sample size: 50
Built by: Benchmarks #4548
Commit: 955c944

render

Version	Avg time	vs
	103.05ms - 108.35ms	-

update

Version	Avg time	vs
	1107.50ms - 1125.64ms	-

update-reflect

Version	Avg time	vs
	1073.83ms - 1093.94ms	-

lit-html-kitchen-sink

Browser: chrome-headless 111.0.5563.64
Sample size: 30
Built by: Benchmarks #4548
Commit: 955c944

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	43.14ms - 46.90ms	-	unsure 🔍 -7% - +7% -2.96ms - +3.05ms	unsure 🔍 -7% - +6% -2.95ms - +2.55ms
tip-of-tree tip-of-tree	42.64ms - 47.32ms	unsure 🔍 -7% - +7% -3.05ms - +2.96ms	-	unsure 🔍 -7% - +6% -3.32ms - +2.84ms
previous-release previous-release	43.21ms - 47.22ms	unsure 🔍 -6% - +7% -2.55ms - +2.95ms	unsure 🔍 -6% - +7% -2.84ms - +3.32ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	107.68ms - 112.40ms	-	unsure 🔍 -3% - +5% -3.13ms - +5.27ms	unsure 🔍 -4% - +3% -4.61ms - +3.49ms
tip-of-tree tip-of-tree	105.50ms - 112.45ms	unsure 🔍 -5% - +3% -5.27ms - +3.13ms	-	unsure 🔍 -6% - +3% -6.41ms - +3.16ms
previous-release previous-release	107.31ms - 113.89ms	unsure 🔍 -3% - +4% -3.49ms - +4.61ms	unsure 🔍 -3% - +6% -3.16ms - +6.41ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	19.79ms - 21.42ms	-	unsure 🔍 -7% - +5% -1.36ms - +1.02ms	unsure 🔍 -5% - +6% -1.05ms - +1.19ms
tip-of-tree tip-of-tree	19.90ms - 21.65ms	unsure 🔍 -5% - +7% -1.02ms - +1.36ms	-	unsure 🔍 -5% - +7% -0.92ms - +1.40ms
previous-release previous-release	19.77ms - 21.30ms	unsure 🔍 -6% - +5% -1.19ms - +1.05ms	unsure 🔍 -7% - +4% -1.40ms - +0.92ms	-

lit-html-repeat

Browser: chrome-headless 111.0.5563.64
Sample size: 30
Built by: Benchmarks #4548
Commit: 955c944

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	13.32ms - 15.60ms	-	unsure 🔍 -7% - +12% -1.04ms - +1.73ms	unsure 🔍 -6% - +13% -0.85ms - +1.87ms
tip-of-tree tip-of-tree	13.33ms - 14.90ms	unsure 🔍 -12% - +7% -1.73ms - +1.04ms	-	unsure 🔍 -7% - +9% -0.92ms - +1.24ms
previous-release previous-release	13.22ms - 14.70ms	unsure 🔍 -13% - +6% -1.87ms - +0.85ms	unsure 🔍 -9% - +6% -1.24ms - +0.92ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	347.35ms - 398.44ms	-	unsure 🔍 -9% - +10% -31.49ms - +36.63ms	unsure 🔍 -9% - +10% -34.11ms - +36.31ms
tip-of-tree tip-of-tree	347.79ms - 392.86ms	unsure 🔍 -10% - +8% -36.63ms - +31.49ms	-	unsure 🔍 -9% - +8% -34.56ms - +31.62ms
previous-release previous-release	347.56ms - 396.03ms	unsure 🔍 -10% - +9% -36.31ms - +34.11ms	unsure 🔍 -9% - +9% -31.62ms - +34.56ms	-

lit-html-template-heavy

Browser: chrome-headless 111.0.5563.64
Sample size: 50
Built by: Benchmarks #4548
Commit: 955c944

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	71.18ms - 73.91ms	-	unsure 🔍 -2% - +5% -1.23ms - +3.56ms	unsure 🔍 -4% - +2% -3.21ms - +1.50ms
tip-of-tree tip-of-tree	69.41ms - 73.35ms	unsure 🔍 -5% - +2% -3.56ms - +1.23ms	-	unsure 🔍 -6% - +1% -4.77ms - +0.73ms
previous-release previous-release	71.48ms - 75.31ms	unsure 🔍 -2% - +4% -1.50ms - +3.21ms	unsure 🔍 -1% - +7% -0.73ms - +4.77ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	151.67ms - 158.24ms	-	unsure 🔍 -2% - +4% -3.53ms - +6.84ms	unsure 🔍 -4% - +2% -6.30ms - +2.81ms
tip-of-tree tip-of-tree	149.29ms - 157.32ms	unsure 🔍 -4% - +2% -6.84ms - +3.53ms	-	unsure 🔍 -5% - +1% -8.51ms - +1.70ms
previous-release previous-release	153.55ms - 159.86ms	unsure 🔍 -2% - +4% -2.81ms - +6.30ms	unsure 🔍 -1% - +6% -1.70ms - +8.51ms	-

reactive-element-list

Browser: chrome-headless 111.0.5563.64
Sample size: 50
Built by: Benchmarks #4548
Commit: 955c944

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	69.78ms - 72.69ms	-	unsure 🔍 -5% - +1% -3.38ms - +0.87ms	faster ✔ 0% - 6% 0.32ms - 4.36ms
tip-of-tree tip-of-tree	70.95ms - 74.03ms	unsure 🔍 -1% - +5% -0.87ms - +3.38ms	-	unsure 🔍 -4% - +1% -3.17ms - +1.01ms
previous-release previous-release	72.17ms - 74.97ms	slower ❌ 0% - 6% 0.32ms - 4.36ms	unsure 🔍 -1% - +4% -1.01ms - +3.17ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1128.11ms - 1150.71ms	-	unsure 🔍 -1% - +2% -12.62ms - +18.22ms	unsure 🔍 -1% - +2% -13.98ms - +17.20ms
tip-of-tree tip-of-tree	1126.12ms - 1147.10ms	unsure 🔍 -2% - +1% -18.22ms - +12.62ms	-	unsure 🔍 -1% - +1% -16.20ms - +13.82ms
previous-release previous-release	1127.07ms - 1148.54ms	unsure 🔍 -2% - +1% -17.20ms - +13.98ms	unsure 🔍 -1% - +1% -13.82ms - +16.20ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1123.11ms - 1144.11ms	-	unsure 🔍 -1% - +2% -12.33ms - +18.00ms	unsure 🔍 -2% - +1% -18.74ms - +12.66ms
tip-of-tree tip-of-tree	1119.84ms - 1141.72ms	unsure 🔍 -2% - +1% -18.00ms - +12.33ms	-	unsure 🔍 -2% - +1% -21.87ms - +10.13ms
previous-release previous-release	1124.98ms - 1148.32ms	unsure 🔍 -1% - +2% -12.66ms - +18.74ms	unsure 🔍 -1% - +2% -10.13ms - +21.87ms	-

_{tachometer-reporter-action v2 for Benchmarks}

augustjk

approving with comment on the packages mentioned in changeset.

augustjk · 2023-03-24T17:10:11Z

.changeset/wild-rabbits-pay.md

+'lit-html': major
+'lit': major
+'lit-element': major
+'@lit/reactive-element': major


theoretically the change is part of the initiative in dropping ie11 support but there were no changes to the vended package so do these need to be added to changeset? i think it only makes sense to keep the starter kits.

it will add a line in the changelog that says "Drop IE11 support" in all the mentioned packages and if that's the intention, then i guess it makes sense. though i would think we'd want to associate actual code changes to that idea. we might need to reorganize the changelog instead of relying on what's generated by changesets for this major release then.

oh, i see there are PRs meant to be merged into this branch, sorry i guess i looked at these in the wrong order, though the PR title here is misleading then.

Yeah, I retroactively made the the base for everything else. So "Drop IE" is accurate in that this drops support... the other PRs take advantage of that. I can change the title of the PR though.

justinfagnani added 3 commits March 23, 2023 19:13

Remove sauce-ie11 workflow

7208f39

Remove sauce-ie11 browser preset

4148656

Remove ie11 and edge launcher examples

2f1c729

justinfagnani requested a review from augustjk March 24, 2023 02:31

justinfagnani added the 3.0 label Mar 24, 2023

Add changeset

48a9bed

justinfagnani force-pushed the 3.0-turndown-ie branch from 9acef39 to 48a9bed Compare March 24, 2023 03:07

augustjk approved these changes Mar 24, 2023

View reviewed changes

justinfagnani changed the title ~~[all] Turndown IE testing~~ [all] Drop IE11 support Mar 24, 2023

justinfagnani merged commit f06f797 into 3.0 Mar 24, 2023

justinfagnani deleted the 3.0-turndown-ie branch March 24, 2023 19:23

This was referenced Apr 26, 2023

Version Packages (3.0) #3846

Closed

Version Packages (pre) #3853

Merged

Conversation

justinfagnani commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

augustjk left a comment

Choose a reason for hiding this comment

Uh oh!

augustjk Mar 24, 2023

Choose a reason for hiding this comment

Uh oh!

augustjk Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinfagnani Mar 24, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

justinfagnani commented Mar 24, 2023 •

edited

Loading

changeset-bot bot commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

augustjk Mar 24, 2023 •

edited

Loading