Reduce requests for example.com from tests#869
Merged
cjmayo merged 2 commits intolinkchecker:masterfrom Jul 28, 2025
Merged
Conversation
8cf8053 to
dbe9a2f
Compare
example.com, example.net and example.org are meant to be used in documentation and there is no guarantee for their HTTP service. This is leading to CI failures. There is still some use of these in checker/test_bookmarks.py and checker/test_http_misc.py.
Identified when http_slash.html "no scheme example" changed to use linkchecker.github.io: tests/checker/test_http.py::TestHttp::test_html_internet /usr/lib/python3.13/site-packages/urllib3/connectionpool.py:1097: InsecureRequestWarning: Unverified HTTPS request is being made to host 'linkchecker.github.io'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings warnings.warn( Since Requests introduced: 7b34be5 ("Introduce check plugins, use Python requests for http/s connections, and some code cleanups and improvements.", 2014-03-01) 6bae3e0 ("Use the same request arguments for redirects.", 2014-04-23) The Requests default for verify is True in Session.send() and Session.resolve_redirects(), and is is recommended to only set it to False for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example.com, example.net and example.org are meant to be used in documentation and there is no guarantee for their HTTP service. This is leading to CI failures.
There is still some use of these in checker/test_bookmarks.py and checker/test_http_misc.py.