Skip to content

fix: fallback to other only when undefined#1665

Merged
andrii-bodnar merged 1 commit intolingui:mainfrom
taozhou-glean:tao-select
May 18, 2023
Merged

fix: fallback to other only when undefined#1665
andrii-bodnar merged 1 commit intolingui:mainfrom
taozhou-glean:tao-select

Conversation

@taozhou-glean
Copy link
Copy Markdown
Contributor

Description

fix #1664

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes #1664

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 4:43am

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.43 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.08 🎉

Comparison is base (f3824e6) 75.48% compared to head (e7bce53) 75.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
+ Coverage   75.48%   75.56%   +0.08%     
==========================================
  Files          79       79              
  Lines        2011     2018       +7     
  Branches      518      519       +1     
==========================================
+ Hits         1518     1525       +7     
  Misses        379      379              
  Partials      114      114              
Impacted Files Coverage Δ
packages/vite-plugin/src/index.ts 0.00% <0.00%> (ø)
...es/cli/src/api/catalog/getCatalogDependentFiles.ts 100.00% <100.00%> (ø)
packages/core/src/interpolate.ts 85.36% <100.00%> (ø)
packages/loader/src/webpackLoader.ts 90.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timofei-iatsenko timofei-iatsenko self-requested a review May 18, 2023 08:08
@andrii-bodnar andrii-bodnar merged commit a79de75 into lingui:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

select fallback to other on falsy choice values (0, empty string)

3 participants