Avoid instantiating arbitrary classes#758
Merged
raboof merged 1 commit intolightbend:mainfrom Feb 1, 2022
Merged
Conversation
havocp
approved these changes
Feb 1, 2022
This PR avoids the use of `Class#newInstance`, which is deprecated in Java 9. In particular, previously you could set the `config.strategy` system to an arbitrary class that would get instantiated even if it was not a subclass of `ConfigLoadingStrategy`. This is now checked before instantiating the class. The previous behavior could arguably be considered a security concern when an attacker has write access to system properties, though in such a scenario there are likely many other ways to load arbitrary code.
74bbcff to
fe85a7d
Compare
vlsi
reviewed
Feb 1, 2022
| } catch (InvocationTargetException e) { | ||
| Throwable cause = e.getCause(); | ||
| if (cause == null) throw new ConfigException.BugOrBroken("Failed to load strategy: " + className, e); | ||
| else throw new ConfigException.BugOrBroken("Failed to load strategy: " + className, cause); |
There was a problem hiding this comment.
❤️ unwrapping InvocationTargetException is great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids the use of
Class#newInstance, which isdeprecated in Java 9.
In particular, previously you could set the
config.strategysystem to an arbitrary class that would get instantiated even
if it was not a subclass of
ConfigLoadingStrategy. This isnow checked before instantiating the class.
The previous behavior could arguably be considered a security
concern when an attacker has write access to system properties,
though in such a scenario there are likely many other ways to
load arbitrary code.
Thanks to @vlsi for identifying this issue.