Skip to content

Support for huge memory units#663

Merged
havocp merged 8 commits intolightbend:masterfrom
mpryahin:master
Feb 17, 2020
Merged

Support for huge memory units#663
havocp merged 8 commits intolightbend:masterfrom
mpryahin:master

Conversation

@mpryahin
Copy link
Contributor

@mpryahin mpryahin commented Dec 26, 2019 •
edited
Loading

Added support for memory units which don't fit in a long when transformed to bytes.
closes #172

@mpryahin mpryahin mentioned this pull request Dec 26, 2019
Closed
havocp
havocp reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall, I think my main suggestion is I'd lean toward removing the code duplication, even if it means we allocate a BigInteger only to range check it and then convert to Long.

havocp
havocp reviewed Jan 10, 2020
View reviewed changes
Copy link
Contributor

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Main remaining issue I think is an ABI break if we go from BadValue=>IllegalArgumentException in a couple of places.

@mpryahin
Copy link
Contributor Author

mpryahin commented Jan 17, 2020

Hello @havocp,
sorry for bothering, could you please review the final changes so that we can merge the PR into the main branch?
Thank you in advance!

havocp
havocp approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience - this looks great to me!

@mpryahin @havocp
Update config/src/main/java/com/typesafe/config/impl/SimpleConfig.java
89afa77 
Co-Authored-By: Havoc Pennington <hp@pobox.com>
@mpryahin
Copy link
Contributor Author

mpryahin commented Jan 18, 2020

@havocp thank you so much! Looking forward to having it merged when you have time.

@mpryahin
Copy link
Contributor Author

mpryahin commented Jan 27, 2020

Hello @havocp ,
I'm sorry for bothering, just writing to ask if there is anything else to be done form my side?
Thank you.

@havocp havocp merged commit d0271d4 into lightbend:master Feb 17, 2020
@havocp
Copy link
Contributor

havocp commented Feb 17, 2020

Thanks! Appreciate the work on this. I don't know when Lightbend will next make a release.

@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
@ekrich ekrich mentioned this pull request Jun 16, 2023
Open
@kastoestoramadus kastoestoramadus mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@havocp havocp havocp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add BigInteger version of getBytes

2 participants

@mpryahin @havocp