fix(issue:4267) support starting-style at-rule#4333
Merged
matthew-dean merged 6 commits intoless:masterfrom Mar 31, 2025
Merged
fix(issue:4267) support starting-style at-rule#4333matthew-dean merged 6 commits intoless:masterfrom
matthew-dean merged 6 commits intoless:masterfrom
Conversation
* Add support for the starting-style at-rule.
* Improve at-rule comment and call handling and add more starting-style at-rule tests.
* Refactor new code introduced to broaded at-rule support for starting-syle at-rule and other at-rules.
* Cleanup at-rule enhancement code for starting-style at-rule support.
This was referenced Mar 29, 2025
Member
|
Thank you! Do you know why checks show as cancelled or failed? |
* Pin Playwright to exact version to try to resolve CI issues.
Contributor
Author
|
I thought I made it an exact version here ( |
matthew-dean
approved these changes
Mar 31, 2025
Contributor
Author
|
Thank you for reviewing and merging. I will try to prepare a release PR around this Friday so we can ship |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
This pull request resolves issue #4267 by fixing @starting-style at-rule nesting.
Why:
Users of Less.js may wish to use newer features of CSS supported by newer versions of most browsers. Estimated support for @starting-style is 86.48%+ (https://caniuse.com/mdn-css_at-rules_starting-style).
Checklist:
Per comment on #4289 I worked to add support for the
starting-styleat-rule by bolstering baseAtRuletree node capabilities.The following Less:
becomes: