fix(issue:4301) at-rule declarations missing#4302
Merged
matthew-dean merged 1 commit intoless:masterfrom Jan 2, 2025
Merged
Conversation
* Fixes issue less#4301. At-rule declarations may go missing or are incorrectly merged under certain nesting conditions. * Added more ```@container``` tests.
Contributor
Author
|
CI seems flaky. |
This was referenced Dec 19, 2024
At-rule declarations may go missing are or incorrectly merged under certain nesting conditions
#4301
Closed
Contributor
Author
|
Would either of you mind reviewing this PR? @matthew-dean @iChenLei This PR should also pre-emptively resolve issues that would arise from #4289 |
matthew-dean
approved these changes
Jan 2, 2025
puckowski
added a commit
to puckowski/less.js
that referenced
this pull request
Jan 17, 2025
* Fixes issue less#4301. At-rule declarations may go missing or are incorrectly merged under certain nesting conditions. * Added more ```@container``` tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
@containertests.Why:
User raised an issue in #4267 (comment) where they noted @media and
@containerare not properly nesting in some cases.Shared at-rule function was incorrectly assuming all nodes in list were of same type, but as of Less.js
4.2.0that is no longer true as@containerquery support was firmed up in that release and can be mixed with@media.Checklist: