Skip to content

fix(issue:3737) allow blank variable declarations#4294

Merged
puckowski merged 1 commit intoless:masterfrom
puckowski:master_fix_3737
Dec 8, 2024
Merged

fix(issue:3737) allow blank variable declarations#4294
puckowski merged 1 commit intoless:masterfrom
puckowski:master_fix_3737

Conversation

@puckowski
Copy link
Copy Markdown
Contributor

@puckowski puckowski commented Nov 29, 2024

What:

Fixes issue #3737 where blank CSS variable declarations resulted in parsing errors.

Why:

Blank CSS variables are valid.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

Existing tests are passing locally.

The following Less.js:

*, ::before, ::after {
  --tw-pan-x:  ;
  --tw-pan-y:  ;
  --tw-pinch-zoom:  ;
  --tw-scroll-snap-strictness: proximity;
}

becomes:

*,
::before,
::after {
  --tw-pan-x: ;
  --tw-pan-y: ;
  --tw-pinch-zoom: ;
  --tw-scroll-snap-strictness: proximity;
}

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 29, 2024
@puckowski puckowski mentioned this pull request Nov 29, 2024
Closed
@puckowski
Copy link
Copy Markdown
Contributor Author

puckowski commented Nov 29, 2024

I submitted a few PRs. I expect rebase(s) will be needed in order to merge all of them, so let me know when a rebase is needed.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 7, 2024
@matthew-dean
Copy link
Copy Markdown
Member

matthew-dean commented Dec 7, 2024

@puckowski Looks like we have a merge conflict now

@puckowski
fix(issue:3737) allow blank variable declarations
b6656b0 
* Fixes issue with blank CSS variable declarations.
@puckowski
Copy link
Copy Markdown
Contributor Author

puckowski commented Dec 8, 2024

Tests passing locally. CI looks flaky.

@puckowski
Copy link
Copy Markdown
Contributor Author

puckowski commented Dec 8, 2024

Rebased after merge conflict. Changes approved by one reviewer. Squashing and merging to avoid future merge conflicts.

@puckowski puckowski merged commit 509a007 into less:master Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthew-dean matthew-dean matthew-dean approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@puckowski @matthew-dean