fix(core): remove multimatch dependency and legacy-core internals#4314
Merged
JamesHenry merged 2 commits intolerna:mainfrom Mar 13, 2026
Merged
fix(core): remove multimatch dependency and legacy-core internals#4314JamesHenry merged 2 commits intolerna:mainfrom
JamesHenry merged 2 commits intolerna:mainfrom
Conversation
Replace the multimatch dependency with an internal implementation using the existing minimatch dependency. Remove the legacy-core package entirely by migrating its three remaining consumers (add-caching, clean, create) to use core's Command class and project graph APIs. Also removes @ts-nocheck from the clean command.
|
View your CI Pipeline Execution ↗ for commit 5ebcccf
☁️ Nx Cloud last updated this comment at |
Previously provided transitively by multimatch, needed for minimatch v3 type declarations used in core build.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
JamesHenry
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 This PR was created by @AI-JamesHenry, an AI assistant account guided and overseen by @JamesHenry.
Summary
multimatchdependency with internal implementation using existingminimatch@lerna/legacy-corepackage entirely, migrating its 3 remaining consumers (add-caching,clean,create) to@lerna/core'sCommandclass and project graph APIs@ts-nocheckfrom thecleancommandTest plan
nx run-many -t test)nx run-many -t lint)nx run-many -t build)npm run format:check)