fix(deps): add missing ci-info dependency#4263
Conversation
|
Hi, I've been testing the new npm install-strategy = "linked" and Lerna fails consistently because it attempts to require('ci-info') in libs/core/src/lib/oidc.ts. Since it's not explicitly declared in Lerna's dependencies, the "linked" strategy (which is very strict with phantom dependencies) blocks access to it. Example/Reproduction Branch: Note: In this branch, I've had to manually add ci-info to my root package.json as a workaround to keep the CI running. If I remove that line, Lerna immediately fails with the following trace: Error: Cannot find module 'ci-info' .../node_modules/lerna/dist/index.js
.../node_modules/lerna/dist/cli.js
at libs/core/src/lib/oidc.ts (.../node_modules/lerna/dist/index.js:5703:30)Thanks for the fix! |
|
View your CI Pipeline Execution ↗ for commit d47edcf
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
Our e2e-repair test is failing due to a pre-existing snapshot mismatch that exists on the main branch. The snapshot needs to be updated to include the new Nx migration (22-7-0-add-polygraph-to-git-ignore), but this is unrelated to the ci-info dependency fix in this PR.
No code changes were suggested for this issue.
You can trigger a rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🎓 Learn more about Self-Healing CI on nx.dev
|
I will fix the snapshot and sync up |
Description
In d51e344, we added code that uses the
ci-infopackage, but we did not add a dependency onci-infotopackage.json; as a result, strict environments (e.g. Yarn Plug'n'Play) show an error like this:Motivation and Context
See above.
How Has This Been Tested?
N/A
Types of changes
Checklist: