Skip to content

feat(version): custom tag-version-separator for independent projects#3951

Merged
JamesHenry merged 1 commit intomainfrom
tag-version-separator
Feb 5, 2024
Merged

feat(version): custom tag-version-separator for independent projects#3951
JamesHenry merged 1 commit intomainfrom
tag-version-separator

Conversation

@JamesHenry
Copy link
Copy Markdown
Member

@JamesHenry JamesHenry commented Feb 5, 2024

Description

Allows users to customize the tag version separator for independent projects in cases where they do not want to use the default of @.

Example usage can be seen in the e2e test for this project.

Motivation and Context

Closes #3902 #3837

How Has This Been Tested?

e2e and unit tests added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Feb 5, 2024

@JamesHenry JamesHenry marked this pull request as ready for review February 5, 2024 16:28
@JamesHenry JamesHenry merged commit 43de79c into main Feb 5, 2024
@JamesHenry JamesHenry deleted the tag-version-separator branch February 5, 2024 16:29
@briananstett
Copy link
Copy Markdown
Contributor

I created a new issue for the GitHub Release failure created from this change. I believe the issue is with this line of code

#3974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom tag template when independent versioning

2 participants