Skip to content

feat(version): use corepack for install when enabled#3877

Merged
JamesHenry merged 23 commits intolerna:mainfrom
fahslaj:feat/use-corepack-when-enabled
Nov 21, 2023
Merged

feat(version): use corepack for install when enabled#3877
JamesHenry merged 23 commits intolerna:mainfrom
fahslaj:feat/use-corepack-when-enabled

Conversation

@fahslaj
Copy link
Copy Markdown
Contributor

@fahslaj fahslaj commented Oct 26, 2023

Description

Use corepack for install commands when it is enabled & use corepack in CI for package manager setup. Update tests to expect pnpm version 8.

When lerna is run via:

corepack yarn lerna version

then the install command run by the version command will be:

corepack yarn install

Motivation and Context

#3867

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj force-pushed the feat/use-corepack-when-enabled branch from 63c428c to f8c778c Compare October 26, 2023 23:33
@fahslaj fahslaj changed the base branch from main to v8 October 30, 2023 18:38
@fahslaj fahslaj changed the base branch from v8 to main November 8, 2023 22:07
chore: split corepack e2e tests into two modules

chore: use corepack for pnpm in CI

chore: remove manual install of pnpm

chore: move corepack enable inside install dependencies yml

chore: move corepack install to ci script

chore: use pnpm 8+
@fahslaj fahslaj force-pushed the feat/use-corepack-when-enabled branch from 3cbba10 to 7d1a9b6 Compare November 16, 2023 15:47
@fahslaj fahslaj marked this pull request as ready for review November 21, 2023 05:36
@fahslaj fahslaj requested a review from JamesHenry November 21, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants