Skip to content

fix(core): update package engines.node to correctly include only >=16#3861

Merged
JamesHenry merged 1 commit intolerna:mainfrom
fahslaj:fix/update-node-engine-requirement
Oct 10, 2023
Merged

fix(core): update package engines.node to correctly include only >=16#3861
JamesHenry merged 1 commit intolerna:mainfrom
fahslaj:fix/update-node-engine-requirement

Conversation

@fahslaj
Copy link
Copy Markdown
Contributor

@fahslaj fahslaj commented Oct 10, 2023

Description

Updates package.json files to properly exclude Node 14.

Motivation and Context

Node 14 reached end of life on Apr 30th, 2023 (https://endoflife.date/nodejs), which was two months before the release of Lerna v7. Lerna v7 never intended to support Node 14 and the persistence of ^v14.17.0 in the package.json engines.node property for Lerna@^7 was an oversight.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj force-pushed the fix/update-node-engine-requirement branch from 3dc01e0 to 2dfc559 Compare October 10, 2023 16:32
@fahslaj fahslaj marked this pull request as ready for review October 10, 2023 17:04
@fahslaj fahslaj requested a review from JamesHenry October 10, 2023 17:04
@JamesHenry JamesHenry merged commit 0674555 into lerna:main Oct 10, 2023
@JamesHenry JamesHenry deleted the fix/update-node-engine-requirement branch October 10, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants