Pgsql cube type compile fail#3459
Merged
abonander merged 3 commits intolaunchbadge:mainfrom Aug 26, 2024
kdesjard:pgsql_cube_type_compile_fail
Merged
Pgsql cube type compile fail#3459abonander merged 3 commits intolaunchbadge:mainfrom kdesjard:pgsql_cube_type_compile_fail
abonander merged 3 commits intolaunchbadge:mainfrom
kdesjard:pgsql_cube_type_compile_fail
Conversation
Contributor
|
Could you add the following to your PR-description? (this way, other users have a link to follow) |
Collaborator
|
@kdesjard |
11 tasks
|
@kdesjard could you please run |
Contributor
Author
|
I did push a commit f47ce6b Am I missing something? |
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
* fails to compile as size_of is not found in scope * keep scoping consistent with other type modules * fmt fixes --------- Co-authored-by: kdesjard <kristian.desjardins@nrcan-rncan.gc.ca>
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
* fails to compile as size_of is not found in scope * keep scoping consistent with other type modules * fmt fixes --------- Co-authored-by: kdesjard <kristian.desjardins@nrcan-rncan.gc.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Resolves #3461
Resolves #3460
Replaces #3457
Replaces #3456
The Postgresql cube type fails to compile in version 0.8.1:
The PR includes a patch for this as well as a scoping change for the hstore type to keep it consistent with the others.