Skip to content

fix(#3445): PgHasArrayType#3453

Merged
abonander merged 2 commits intolaunchbadge:mainfrom
joeydewaal:PgHasArrayType-fix
Aug 25, 2024
Merged

fix(#3445): PgHasArrayType#3453
abonander merged 2 commits intolaunchbadge:mainfrom
joeydewaal:PgHasArrayType-fix

Conversation

@joeydewaal
Copy link
Copy Markdown
Contributor

@joeydewaal joeydewaal commented Aug 23, 2024

Does your PR solve an issue?

Fixes an issue with PgHasArrayType.
Fixes: #3445

Copy link
Copy Markdown
Collaborator

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a small regression test for this? https://github.com/launchbadge/sqlx/blob/main/tests/postgres/derives.rs

@joeydewaal
Copy link
Copy Markdown
Contributor Author

Done!

@CommanderStorm
Copy link
Copy Markdown
Contributor

@joeydewaal FYI: if you write Fixes: #3445 instead of the format used by you, github will link this PR to said issue and enables auto-closing of said issue once this PR is merged ^^

@joeydewaal
Copy link
Copy Markdown
Contributor Author

Alright, good to know thank you. I updated it!

@abonander abonander merged commit ebf04ff into launchbadge:main Aug 25, 2024
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
* fix(launchbadge#3445): PgHasArrayType

* regression test for custom no_pg_array
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
* fix(launchbadge#3445): PgHasArrayType

* regression test for custom no_pg_array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the Type derive in 0.8 seems to generate a PgHasArrayType impl

3 participants