fix: Use rfc3339 to decode date from text#3411
Merged
abonander merged 1 commit intolaunchbadge:mainfrom Sep 2, 2024
Merged
Conversation
de9eab2 to
ca7931a
Compare
ca7931a to
3e9473c
Compare
Contributor
Author
|
@abonander @CommanderStorm Any chance this can be reviewed soon? |
Contributor
|
@pierre-wehbe You opened the PR 11h ago and and are already pinging? |
CommanderStorm
suggested changes
Aug 7, 2024
Contributor
CommanderStorm
left a comment
There was a problem hiding this comment.
idk why you tagged me. I am not a maintainer, just a fellow contibutor ^^
Could you attach a testcase here to ensure that no regressions on this can happen in the future (and to ensure that this acutally fixes the issue linked, not doubting that it does):
Contributor
Author
|
@CommanderStorm Already overwrote the cargo deps. Wasn't sure how to get the PR visibility since no Reviewers were assigned. |
Collaborator
|
It's generally just me, and I get to it when I get to it. |
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
#703 (comment)
Fix inspired by https://github.com/launchbadge/sqlx/pull/1618/files