[3.x] Return correct exit code on exceptions#165
Merged
taylorotwell merged 2 commits intolaravel:masterfrom Jul 10, 2023
Merged
[3.x] Return correct exit code on exceptions#165taylorotwell merged 2 commits intolaravel:masterfrom
taylorotwell merged 2 commits intolaravel:masterfrom
Conversation
driesvints
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the behaviour of the
--executeoption to have it return an exit code of 1 when an exception is thrown.Currently all exceptions are caught and rendered by Psysh internally, which makes it difficult to determine whether the command succeeded.
Original PR
Reopened on master branch as per #163 (comment)