[12.x] Refactor: simplify code#58820
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Feb 14, 2026
Merged
Conversation
Contributor
Author
|
Un related test failed |
DarkGhostHunter
pushed a commit
to DarkGhostHunter/laravel-framework
that referenced
this pull request
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify
castBinding()by removing redundant enum checkChanges
This PR simplifies the
castBindingmethod by removing the redundantinstanceof UnitEnumcheck and directly callingenum_value().Rationale
The current implementation checks if the value is a
UnitEnumbefore callingenum_value():However, the
enum_value()helper already handles all these cases internally using a match expression:Since
enum_value()already returns the original value when it's not an enum (via thedefaultcase), we can simplifycastBindingto:Benefits
enum_value()